Skip to content

[Clang] Support __bf16 type for SPIR/SPIR-V #169012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −8
Open

[Clang] Support __bf16 type for SPIR/SPIR-V #169012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions clang/lib/Basic/Targets/SPIR.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ class LLVM_LIBRARY_VISIBILITY BaseSPIRTargetInfo : public TargetInfo {
UseAddrSpaceMapMangling = true;
HasFastHalfType = true;
HasFloat16 = true;
HasBFloat16 = true;
HasFullBFloat16 = true;
BFloat16Width = BFloat16Align = 16;
BFloat16Format = &llvm::APFloat::BFloat();
// Define available target features
// These must be defined in sorted order!
NoAsmVariants = true;
Expand Down Expand Up @@ -427,18 +431,13 @@ class LLVM_LIBRARY_VISIBILITY SPIRV64AMDGCNTargetInfo final
resetDataLayout("e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-"
"v256:256-v512:512-v1024:1024-n32:64-S32-G1-P4-A0");

BFloat16Width = BFloat16Align = 16;
BFloat16Format = &llvm::APFloat::BFloat();

HasFastHalfType = true;
HasFloat16 = true;
HalfArgsAndReturns = true;

MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
}

bool hasBFloat16Type() const override { return true; }

ArrayRef<const char *> getGCCRegNames() const override;

BuiltinVaListKind getBuiltinVaListKind() const override {
Expand Down
31 changes: 31 additions & 0 deletions clang/test/CodeGenOpenCL/__bf16.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// RUN: %clang_cc1 %s -cl-std=cl3.0 -emit-llvm -o - -triple spir-unknown-unknown | FileCheck %s
// RUN: %clang_cc1 %s -cl-std=cl3.0 -emit-llvm -o - -triple spirv64-unknown-unknown | FileCheck %s

kernel void test(global __bf16 *a, global __bf16 *b){
// CHECK-LABEL: spir_kernel void @test(
// CHECK: fadd bfloat
// CHECK: fsub bfloat
// CHECK: fmul bfloat
// CHECK: fdiv bfloat

*b += *a;
*b -= *a;
*b *= *a;
*b /= *a;
}

typedef __bf16 __bf16v4 __attribute((ext_vector_type(4)));

kernel void test_v4(global __bf16v4 *a, global __bf16v4 *b){
// CHECK-LABEL: spir_kernel void @test_v4(
// CHECK: fadd <4 x bfloat>
// CHECK: fsub <4 x bfloat>
// CHECK: fmul <4 x bfloat>
// CHECK: fdiv <4 x bfloat>

*b += *a;
*b -= *a;
*b *= *a;
*b /= *a;
}

7 changes: 4 additions & 3 deletions clang/test/SemaSYCL/bf16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// RUN: %clang_cc1 -triple spir64 -aux-triple x86_64-unknown-linux-gnu -fsycl-is-device -verify -fsyntax-only %s
// expected-no-diagnostics

template <typename Name, typename Func>
__attribute__((sycl_kernel)) void kernel(const Func &kernelFunc) {
kernelFunc(); // expected-note {{called by 'kernel}}
kernelFunc();
}

void host_ok(void) {
Expand All @@ -11,9 +12,9 @@ void host_ok(void) {

int main()
{ host_ok();
__bf16 var; // expected-note {{'var' defined here}}
__bf16 var;
kernel<class variables>([=]() {
(void)var; // expected-error {{'var' requires 16 bit size '__bf16' type support, but target 'spir64' does not support it}}
(void)var;
int B = sizeof(__bf16);
});

Expand Down