Skip to content

[MLIR][LLVM] Support named barrier as a global variable type in llvm dialect #169194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2025
Merged

[MLIR][LLVM] Support named barrier as a global variable type in llvm dialect #169194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f481b21
Add support for named barrier as a global variable type in MLIR's llv…
PMylon Nov 22, 2025
920cda5
Merge branch 'main' into named-barrier-global-var-mlir-support
PMylon Nov 23, 2025
57aaaae
Merge branch 'main' into named-barrier-global-var-mlir-support
PMylon Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,7 @@ LogicalResult LLVMStructType::verifyEntries(DataLayoutEntryListRef entries,

static constexpr llvm::StringRef kSpirvPrefix = "spirv.";
static constexpr llvm::StringRef kArmSVCount = "aarch64.svcount";
static constexpr llvm::StringRef kAMDGCNNamedBarrier = "amdgcn.named.barrier";

bool LLVM::LLVMTargetExtType::hasProperty(Property prop) const {
// See llvm/lib/IR/Type.cpp for reference.
Expand All @@ -676,6 +677,9 @@ bool LLVM::LLVMTargetExtType::hasProperty(Property prop) const {
properties |=
(LLVMTargetExtType::HasZeroInit | LLVM::LLVMTargetExtType::CanBeGlobal);

if (getExtTypeName() == kAMDGCNNamedBarrier)
properties |= LLVMTargetExtType::CanBeGlobal;

return (properties & prop) == prop;
}

Expand Down
6 changes: 6 additions & 0 deletions mlir/test/Target/LLVMIR/target-ext-type.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ llvm.mlir.global external @global() {addr_space = 0 : i32} : !llvm.target<"spirv
llvm.return %0 : !llvm.target<"spirv.DeviceEvent">
}

// CHECK: @amdgcn_named_barrier = internal addrspace(3) global target("amdgcn.named.barrier", 0) poison
llvm.mlir.global internal @amdgcn_named_barrier() {addr_space = 3 : i32} : !llvm.target<"amdgcn.named.barrier", 0> {
%0 = llvm.mlir.poison : !llvm.target<"amdgcn.named.barrier", 0>
llvm.return %0 : !llvm.target<"amdgcn.named.barrier", 0>
}

// CHECK-LABEL: define target("spirv.Event") @func2() {
// CHECK-NEXT: %1 = alloca target("spirv.Event"), align 8
// CHECK-NEXT: %2 = load target("spirv.Event"), ptr %1, align 8
Expand Down