Skip to content

Conversation

@baramatsubonzo
Copy link
Contributor

@baramatsubonzo baramatsubonzo commented Nov 24, 2025

This patch fixes a minor typo in the Kaleidoscope tutorial (Chapter 2).

The sentence:
“checks to see if if is too low”
has been corrected to:
“checks to see if it is too low”.

This is a documentation-only change and does not affect any semantic behavior or code generation.

Thank you for maintaining the tutorial, and please let me know if any further adjustments are needed.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@melver melver merged commit 38a5dd5 into llvm:main Nov 24, 2025
11 checks passed
@github-actions
Copy link

@baramatsubonzo Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

aadeshps-mcw pushed a commit to aadeshps-mcw/llvm-project that referenced this pull request Nov 26, 2025
This patch fixes a minor typo in the **Kaleidoscope tutorial (Chapter
2)**.

The sentence:
“checks to see if **if** is too low”
has been corrected to:
“checks to see if **it** is too low”.

This is a documentation-only change and does not affect any semantic
behavior or code generation.

Thank you for maintaining the tutorial, and please let me know if any
further adjustments are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants