Skip to content

[X86] combineConcatVectorOps - add handling to concat RCPPS/RSQRTPS intrinsics together #170148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RKSimon merged 1 commit into from
Dec 1, 2025
Merged

[X86] combineConcatVectorOps - add handling to concat RCPPS/RSQRTPS intrinsics together #170148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59464,6 +59464,12 @@ static SDValue combineConcatVectorOps(const SDLoc &DL, MVT VT,
return DAG.getNode(Opcode, DL, VT, ConcatSubOperand(VT, Ops, 0));
}
break;
case X86ISD::FRCP:
case X86ISD::FRSQRT:
if (!IsSplat && VT.is256BitVector()) {
return DAG.getNode(Opcode, DL, VT, ConcatSubOperand(VT, Ops, 0));
}
break;
case X86ISD::HADD:
case X86ISD::HSUB:
case X86ISD::FHADD:
Expand Down
24 changes: 12 additions & 12 deletions llvm/test/CodeGen/X86/combine-rcp.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ define <8 x float> @concat_rcp_v8f32_v4f32(<4 x float> %a0, <4 x float> %a1) {
;
; AVX-LABEL: concat_rcp_v8f32_v4f32:
; AVX: # %bb.0:
; AVX-NEXT: vrcpps %xmm0, %xmm0
; AVX-NEXT: vrcpps %xmm1, %xmm1
; AVX-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX-NEXT: vrcpps %ymm0, %ymm0
; AVX-NEXT: retq
%v0 = call <4 x float> @llvm.x86.sse.rcp.ps(<4 x float> %a0)
%v1 = call <4 x float> @llvm.x86.sse.rcp.ps(<4 x float> %a1)
Expand All @@ -36,23 +36,23 @@ define <16 x float> @concat_rcp_v16f32_v4f32(<4 x float> %a0, <4 x float> %a1, <
;
; AVX1OR2-LABEL: concat_rcp_v16f32_v4f32:
; AVX1OR2: # %bb.0:
; AVX1OR2-NEXT: vrcpps %xmm0, %xmm0
; AVX1OR2-NEXT: vrcpps %xmm1, %xmm1
; AVX1OR2-NEXT: vrcpps %xmm2, %xmm2
; AVX1OR2-NEXT: vrcpps %xmm3, %xmm3
; AVX1OR2-NEXT: # kill: def $xmm2 killed $xmm2 def $ymm2
; AVX1OR2-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX1OR2-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX1OR2-NEXT: vrcpps %ymm0, %ymm0
; AVX1OR2-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm1
; AVX1OR2-NEXT: vrcpps %ymm1, %ymm1
; AVX1OR2-NEXT: retq
;
; AVX512-LABEL: concat_rcp_v16f32_v4f32:
; AVX512: # %bb.0:
; AVX512-NEXT: vrcpps %xmm0, %xmm0
; AVX512-NEXT: vrcpps %xmm1, %xmm1
; AVX512-NEXT: vrcpps %xmm2, %xmm2
; AVX512-NEXT: vrcpps %xmm3, %xmm3
; AVX512-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm2
; AVX512-NEXT: # kill: def $xmm2 killed $xmm2 def $ymm2
; AVX512-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX512-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX512-NEXT: vinsertf64x4 $1, %ymm2, %zmm0, %zmm0
; AVX512-NEXT: vrcpps %ymm0, %ymm0
; AVX512-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm1
; AVX512-NEXT: vrcpps %ymm1, %ymm1
; AVX512-NEXT: vinsertf64x4 $1, %ymm1, %zmm0, %zmm0
; AVX512-NEXT: retq
%v0 = call <4 x float> @llvm.x86.sse.rcp.ps(<4 x float> %a0)
%v1 = call <4 x float> @llvm.x86.sse.rcp.ps(<4 x float> %a1)
Expand Down
24 changes: 12 additions & 12 deletions llvm/test/CodeGen/X86/combine-rsqrt.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ define <8 x float> @concat_rsqrt_v8f32_v4f32(<4 x float> %a0, <4 x float> %a1) {
;
; AVX-LABEL: concat_rsqrt_v8f32_v4f32:
; AVX: # %bb.0:
; AVX-NEXT: vrsqrtps %xmm0, %xmm0
; AVX-NEXT: vrsqrtps %xmm1, %xmm1
; AVX-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX-NEXT: vrsqrtps %ymm0, %ymm0
; AVX-NEXT: retq
%v0 = call <4 x float> @llvm.x86.sse.rsqrt.ps(<4 x float> %a0)
%v1 = call <4 x float> @llvm.x86.sse.rsqrt.ps(<4 x float> %a1)
Expand All @@ -36,23 +36,23 @@ define <16 x float> @concat_rsqrt_v16f32_v4f32(<4 x float> %a0, <4 x float> %a1,
;
; AVX1OR2-LABEL: concat_rsqrt_v16f32_v4f32:
; AVX1OR2: # %bb.0:
; AVX1OR2-NEXT: vrsqrtps %xmm0, %xmm0
; AVX1OR2-NEXT: vrsqrtps %xmm1, %xmm1
; AVX1OR2-NEXT: vrsqrtps %xmm2, %xmm2
; AVX1OR2-NEXT: vrsqrtps %xmm3, %xmm3
; AVX1OR2-NEXT: # kill: def $xmm2 killed $xmm2 def $ymm2
; AVX1OR2-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX1OR2-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX1OR2-NEXT: vrsqrtps %ymm0, %ymm0
; AVX1OR2-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm1
; AVX1OR2-NEXT: vrsqrtps %ymm1, %ymm1
; AVX1OR2-NEXT: retq
;
; AVX512-LABEL: concat_rsqrt_v16f32_v4f32:
; AVX512: # %bb.0:
; AVX512-NEXT: vrsqrtps %xmm0, %xmm0
; AVX512-NEXT: vrsqrtps %xmm1, %xmm1
; AVX512-NEXT: vrsqrtps %xmm2, %xmm2
; AVX512-NEXT: vrsqrtps %xmm3, %xmm3
; AVX512-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm2
; AVX512-NEXT: # kill: def $xmm2 killed $xmm2 def $ymm2
; AVX512-NEXT: # kill: def $xmm0 killed $xmm0 def $ymm0
; AVX512-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; AVX512-NEXT: vinsertf64x4 $1, %ymm2, %zmm0, %zmm0
; AVX512-NEXT: vrsqrtps %ymm0, %ymm0
; AVX512-NEXT: vinsertf128 $1, %xmm3, %ymm2, %ymm1
; AVX512-NEXT: vrsqrtps %ymm1, %ymm1
; AVX512-NEXT: vinsertf64x4 $1, %ymm1, %zmm0, %zmm0
; AVX512-NEXT: retq
%v0 = call <4 x float> @llvm.x86.sse.rsqrt.ps(<4 x float> %a0)
%v1 = call <4 x float> @llvm.x86.sse.rsqrt.ps(<4 x float> %a1)
Expand Down
Loading