[mlir][spirv] Rename *.spv tests to *.spvasm.
#170161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames two of the SPIR-V tests to `*.spvasm` since both files are assembly files, rather than SPIR-V binaries. The `lit.cfg.py` is adjusted and we no longer need to run `*.spv` tests since none are present.
Member
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-spirv Author: Igor Wodiany (IgWod-IMG) ChangesThis patch renames two of the SPIR-V tests to Full diff: https://github.com/llvm/llvm-project/pull/170161.diff 3 Files Affected:
diff --git a/mlir/test/Target/SPIRV/consecutive-selection.spv b/mlir/test/Target/SPIRV/consecutive-selection.spvasm
similarity index 100%
rename from mlir/test/Target/SPIRV/consecutive-selection.spv
rename to mlir/test/Target/SPIRV/consecutive-selection.spvasm
diff --git a/mlir/test/Target/SPIRV/selection.spv b/mlir/test/Target/SPIRV/selection.spvasm
similarity index 100%
rename from mlir/test/Target/SPIRV/selection.spv
rename to mlir/test/Target/SPIRV/selection.spvasm
diff --git a/mlir/test/lit.cfg.py b/mlir/test/lit.cfg.py
index 7081c51994ec1..675ded35d98f3 100644
--- a/mlir/test/lit.cfg.py
+++ b/mlir/test/lit.cfg.py
@@ -44,7 +44,7 @@
".test",
".pdll",
".c",
- ".spv",
+ ".spvasm",
]
# test_source_root: The root path where tests are located.
|
kuhar
approved these changes
Dec 1, 2025
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
This patch renames two of the SPIR-V tests to `*.spvasm` since both files are assembly files, rather than SPIR-V binaries. The `lit.cfg.py` is adjusted and we no longer need to run `*.spv` tests since none are present.
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
This patch renames two of the SPIR-V tests to `*.spvasm` since both files are assembly files, rather than SPIR-V binaries. The `lit.cfg.py` is adjusted and we no longer need to run `*.spv` tests since none are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames two of the SPIR-V tests to
*.spvasmsince both files are assembly files, rather than SPIR-V binaries. Thelit.cfg.pyis adjusted and we no longer need to run*.spvtests since none are present.