[AMDGPU] Removal of language sensitive option for _Float16 and half('e') handling #170443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) ClangClang.CodeGen/builtins-extended-image.cClang.SemaOpenCL/builtins-extended-image-param-gfx1100-err.clClang.SemaOpenCL/builtins-extended-image-param-gfx942-err.clIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
llvmbot
added
clang
shiltian
approved these changes
Dec 3, 2025
Member
|
@llvm/pr-subscribers-clang Author: Rana Pratap Reddy (ranapratap55) ChangesRemoving the 'e' handling for the amdgcn builtins as we decided to use _Float16 for both HIP/C++ and OpenCL Full diff: https://github.com/llvm/llvm-project/pull/170443.diff 2 Files Affected:
diff --git a/clang/include/clang/Basic/Builtins.def b/clang/include/clang/Basic/Builtins.def
index 3a5b72e20afab..b856ad145824d 100644
--- a/clang/include/clang/Basic/Builtins.def
+++ b/clang/include/clang/Basic/Builtins.def
@@ -43,7 +43,6 @@
// SJ -> sigjmp_buf
// K -> ucontext_t
// p -> pid_t
-// e -> _Float16 for HIP/C++ and __fp16 for OpenCL
// . -> "...". This may only occur at the end of the function list.
//
// Types may be prefixed with the following modifiers:
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index b359fc8350375..a04dcabdaa6b6 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -12402,12 +12402,8 @@ static QualType DecodeTypeFromStr(const char *&Str, const ASTContext &Context,
// Read the base type.
switch (*Str++) {
- default: llvm_unreachable("Unknown builtin type letter!");
- case 'e':
- assert(HowLong == 0 && !Signed && !Unsigned &&
- "Bad modifiers used with 'e'!");
- Type = Context.getLangOpts().OpenCL ? Context.HalfTy : Context.Float16Ty;
- break;
+ default:
+ llvm_unreachable("Unknown builtin type letter!");
case 'x':
assert(HowLong == 0 && !Signed && !Unsigned &&
"Bad modifiers used with 'x'!");
|
ranapratap55
force-pushed
the
users/ranapratap55/Removal-of-e-handling
branch
from
d3017f9 to
b1b3629
Compare
🪟 Windows x64 Test Results
Failed Tests(click on a test name to see its output) ClangClang.CodeGen/builtins-extended-image.cClang.SemaOpenCL/builtins-extended-image-param-gfx1100-err.clClang.SemaOpenCL/builtins-extended-image-param-gfx942-err.clIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the 'e' handling for the amdgcn builtins as we decided to use _Float16 for both HIP/C++ and OpenCL