Skip to content

[flang][Evaluate] Add IntrinsicCall::impureFunction to RAND and IRAND #170492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDPailleux merged 1 commit into from
Dec 4, 2025
Merged

[flang][Evaluate] Add IntrinsicCall::impureFunction to RAND and IRAND #170492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flang/include/flang/Evaluate/intrinsics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ struct SpecificIntrinsicFunctionInterface : public characteristics::Procedure {
// Generic intrinsic classes from table 16.1
ENUM_CLASS(IntrinsicClass, atomicSubroutine, collectiveSubroutine,
elementalFunction, elementalSubroutine, inquiryFunction, pureSubroutine,
impureSubroutine, transformationalFunction, noClass)
impureFunction, impureSubroutine, transformationalFunction, noClass)

class IntrinsicProcTable {
private:
Expand Down
9 changes: 6 additions & 3 deletions flang/lib/Evaluate/intrinsics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,8 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
{"irand",
{{"i", TypePattern{IntType, KindCode::exactKind, 4}, Rank::scalar,
Optionality::optional}},
TypePattern{IntType, KindCode::exactKind, 4}, Rank::scalar},
TypePattern{IntType, KindCode::exactKind, 4}, Rank::scalar,
IntrinsicClass::impureFunction},
{"ishft", {{"i", SameIntOrUnsigned}, {"shift", AnyInt}}, SameIntOrUnsigned},
{"ishftc",
{{"i", SameIntOrUnsigned}, {"shift", AnyInt},
Expand Down Expand Up @@ -879,7 +880,8 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
{"rand",
{{"i", TypePattern{IntType, KindCode::exactKind, 4}, Rank::scalar,
Optionality::optional}},
TypePattern{RealType, KindCode::exactKind, 4}, Rank::scalar},
TypePattern{RealType, KindCode::exactKind, 4}, Rank::scalar,
IntrinsicClass::impureFunction},
{"range",
{{"x", AnyNumeric, Rank::anyOrAssumedRank, Optionality::required,
common::Intent::In,
Expand Down Expand Up @@ -2834,7 +2836,8 @@ std::optional<SpecificCall> IntrinsicInterface::Match(
name, characteristics::Procedure{std::move(dummyArgs), attrs}},
std::move(rearranged)};
} else {
attrs.set(characteristics::Procedure::Attr::Pure);
if (intrinsicClass != IntrinsicClass::impureFunction /* RAND and IRAND */)
attrs.set(characteristics::Procedure::Attr::Pure);
characteristics::TypeAndShape typeAndShape{resultType.value(), resultRank};
characteristics::FunctionResult funcResult{std::move(typeAndShape)};
characteristics::Procedure chars{
Expand Down
9 changes: 9 additions & 0 deletions flang/test/Semantics/doconcurrent01.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ end function ipf
type(procTypeNotPure) :: procVarNotPure
type(procTypePure) :: procVarPure
integer :: ivar
real :: rvar

procVarPure%pureProcComponent => pureFunc

Expand Down Expand Up @@ -239,6 +240,14 @@ end function ipf
ivar = generic()
end do

! This should generate an error
do concurrent (i = 1:10)
!ERROR: Impure procedure 'irand' may not be referenced in DO CONCURRENT
ivar = irand()
!ERROR: Impure procedure 'rand' may not be referenced in DO CONCURRENT
rvar = rand()
end do

contains
integer function notPureFunc()
notPureFunc = 2
Expand Down