[ExposeObjCDirect] Setup helper functions #170617
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This was referenced Dec 4, 2025
🐧 Linux x64 Test Results
|
1. GenerateDirectMethodsPreconditionCheck: Move some functionalities to a separate functions. Those functions will be reused if we move precondition checks into a thunk 2. Create `DirectMethodInfo`, which will be used to manage true implementation and its thunk
DataCorrupted
force-pushed
the
users/DataCorrupted/ExposeDirectMethod-helpers
branch
from
ff65d55 to
b6ddc7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is a stack of PRs implementing features to expose direct methods ABI.
You can see the RFC, design, and discussion here.
#170616 Flag -fexpose-objc-direct set up
#170617 Code refactoring to ease later reviews
#170618 Thunk generation
#170619 Optimizations, some class objects can be known to be realized
Implementation details
GenerateDirectMethodsPreconditionCheck: Move some functionalities to a separate functions. Those functions will be reused if we move precondition checks into a thunkDirectMethodInfo, which will be used to manage true implementation and its thunkTests
None, existing ones shouldn't break