AMDGPU: Create a dummy call sequence when emitting call error #170656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesAt least one special case call lowering tries to parse the call Full diff: https://github.com/llvm/llvm-project/pull/170656.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
index ba80c0695115c..128125d05a3c8 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
@@ -1412,7 +1412,12 @@ SDValue AMDGPUTargetLowering::lowerUnhandledCall(CallLoweringInfo &CLI,
InVals.push_back(DAG.getPOISON(Arg.VT));
}
- return CLI.Chain;
+ // FIXME: Hack because R600 doesn't handle callseq pseudos yet.
+ if (getTargetMachine().getTargetTriple().getArch() == Triple::r600)
+ return CLI.Chain;
+
+ SDValue Chain = DAG.getCALLSEQ_START(CLI.Chain, 0, 0, CLI.DL);
+ return DAG.getCALLSEQ_END(Chain, 0, 0, /*InGlue=*/SDValue(), CLI.DL);
}
SDValue AMDGPUTargetLowering::LowerCall(CallLoweringInfo &CLI,
|
Base automatically changed from
users/arsenm/amdgpu/use-correct-chain-unhandled-call
to
main
December 4, 2025 13:26
ro-i
approved these changes
Dec 4, 2025
Contributor
ro-i
left a comment
ro-i
left a comment
There was a problem hiding this comment.
would the call being a tail call matter? (probably not since this is "unhandled call" anyway)
Contributor
Author
|
Tail calls would be opt-in by the lowering, and we don't try to handle musttail today |
At least one special case call lowering tries to parse the call sequence and asserts when it can't find a callseq_end.
arsenm
force-pushed
the
users/arsenm/amdgpu/create-dummy-call-sequence-error-function
branch
from
6d54816 to
ce03c68
Compare
arsenm
deleted the
users/arsenm/amdgpu/create-dummy-call-sequence-error-function
branch
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…70656) At least one special case call lowering tries to parse the call sequence and asserts when it can't find a callseq_end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one special case call lowering tries to parse the call
sequence and asserts when it can't find a callseq_end.