[NFC][clang] Remove extra To in method name
#170723
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hasPointeeToToCFIUncheckedCalleeFunctionType` -> `hasPointeeToCFIUncheckedCalleeFunctionType`
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: None (PiJoules) Changes
Full diff: https://github.com/llvm/llvm-project/pull/170723.diff 4 Files Affected:
diff --git a/clang/include/clang/AST/TypeBase.h b/clang/include/clang/AST/TypeBase.h
index f07861f50fe8c..30b9efe5a31b7 100644
--- a/clang/include/clang/AST/TypeBase.h
+++ b/clang/include/clang/AST/TypeBase.h
@@ -2607,7 +2607,7 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase {
bool isAnyPointerType() const; // Any C pointer or ObjC object pointer
bool isCountAttributedType() const;
bool isCFIUncheckedCalleeFunctionType() const;
- bool hasPointeeToToCFIUncheckedCalleeFunctionType() const;
+ bool hasPointeeToCFIUncheckedCalleeFunctionType() const;
bool isBlockPointerType() const;
bool isVoidPointerType() const;
bool isReferenceType() const;
@@ -8564,7 +8564,7 @@ inline bool Type::isCFIUncheckedCalleeFunctionType() const {
return false;
}
-inline bool Type::hasPointeeToToCFIUncheckedCalleeFunctionType() const {
+inline bool Type::hasPointeeToCFIUncheckedCalleeFunctionType() const {
QualType Pointee;
if (const auto *PT = getAs<PointerType>())
Pointee = PT->getPointeeType();
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index e842158236cd4..3bde8e1fa2ac3 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -6601,8 +6601,7 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType,
FD && DeviceKernelAttr::isOpenCLSpelling(FD->getAttr<DeviceKernelAttr>()))
CGM.getTargetCodeGenInfo().setOCLKernelStubCallingConvention(FnType);
- bool CFIUnchecked =
- CalleeType->hasPointeeToToCFIUncheckedCalleeFunctionType();
+ bool CFIUnchecked = CalleeType->hasPointeeToCFIUncheckedCalleeFunctionType();
// If we are checking indirect calls and this call is indirect, check that the
// function pointer is a member of the bit set for the function type.
diff --git a/clang/lib/CodeGen/CGPointerAuth.cpp b/clang/lib/CodeGen/CGPointerAuth.cpp
index a49a0c91681fe..84b5c86e69a57 100644
--- a/clang/lib/CodeGen/CGPointerAuth.cpp
+++ b/clang/lib/CodeGen/CGPointerAuth.cpp
@@ -530,7 +530,7 @@ llvm::Constant *CodeGenModule::getMemberFunctionPointer(llvm::Constant *Pointer,
cast_or_null<llvm::ConstantInt>(PointerAuth.getDiscriminator()));
if (const auto *MFT = dyn_cast<MemberPointerType>(FT.getTypePtr())) {
- if (MFT->hasPointeeToToCFIUncheckedCalleeFunctionType())
+ if (MFT->hasPointeeToCFIUncheckedCalleeFunctionType())
Pointer = llvm::NoCFIValue::get(cast<llvm::GlobalValue>(Pointer));
}
diff --git a/clang/lib/CodeGen/ItaniumCXXABI.cpp b/clang/lib/CodeGen/ItaniumCXXABI.cpp
index 65c47633bc5c4..3042f37859e5a 100644
--- a/clang/lib/CodeGen/ItaniumCXXABI.cpp
+++ b/clang/lib/CodeGen/ItaniumCXXABI.cpp
@@ -709,7 +709,7 @@ CGCallee ItaniumCXXABI::EmitLoadOfMemberFunctionPointer(
if (BinOp->isPtrMemOp() &&
BinOp->getRHS()
->getType()
- ->hasPointeeToToCFIUncheckedCalleeFunctionType())
+ ->hasPointeeToCFIUncheckedCalleeFunctionType())
ShouldEmitCFICheck = false;
}
}
|
Member
|
@llvm/pr-subscribers-clang-codegen Author: None (PiJoules) Changes
Full diff: https://github.com/llvm/llvm-project/pull/170723.diff 4 Files Affected:
diff --git a/clang/include/clang/AST/TypeBase.h b/clang/include/clang/AST/TypeBase.h
index f07861f50fe8c..30b9efe5a31b7 100644
--- a/clang/include/clang/AST/TypeBase.h
+++ b/clang/include/clang/AST/TypeBase.h
@@ -2607,7 +2607,7 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase {
bool isAnyPointerType() const; // Any C pointer or ObjC object pointer
bool isCountAttributedType() const;
bool isCFIUncheckedCalleeFunctionType() const;
- bool hasPointeeToToCFIUncheckedCalleeFunctionType() const;
+ bool hasPointeeToCFIUncheckedCalleeFunctionType() const;
bool isBlockPointerType() const;
bool isVoidPointerType() const;
bool isReferenceType() const;
@@ -8564,7 +8564,7 @@ inline bool Type::isCFIUncheckedCalleeFunctionType() const {
return false;
}
-inline bool Type::hasPointeeToToCFIUncheckedCalleeFunctionType() const {
+inline bool Type::hasPointeeToCFIUncheckedCalleeFunctionType() const {
QualType Pointee;
if (const auto *PT = getAs<PointerType>())
Pointee = PT->getPointeeType();
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index e842158236cd4..3bde8e1fa2ac3 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -6601,8 +6601,7 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType,
FD && DeviceKernelAttr::isOpenCLSpelling(FD->getAttr<DeviceKernelAttr>()))
CGM.getTargetCodeGenInfo().setOCLKernelStubCallingConvention(FnType);
- bool CFIUnchecked =
- CalleeType->hasPointeeToToCFIUncheckedCalleeFunctionType();
+ bool CFIUnchecked = CalleeType->hasPointeeToCFIUncheckedCalleeFunctionType();
// If we are checking indirect calls and this call is indirect, check that the
// function pointer is a member of the bit set for the function type.
diff --git a/clang/lib/CodeGen/CGPointerAuth.cpp b/clang/lib/CodeGen/CGPointerAuth.cpp
index a49a0c91681fe..84b5c86e69a57 100644
--- a/clang/lib/CodeGen/CGPointerAuth.cpp
+++ b/clang/lib/CodeGen/CGPointerAuth.cpp
@@ -530,7 +530,7 @@ llvm::Constant *CodeGenModule::getMemberFunctionPointer(llvm::Constant *Pointer,
cast_or_null<llvm::ConstantInt>(PointerAuth.getDiscriminator()));
if (const auto *MFT = dyn_cast<MemberPointerType>(FT.getTypePtr())) {
- if (MFT->hasPointeeToToCFIUncheckedCalleeFunctionType())
+ if (MFT->hasPointeeToCFIUncheckedCalleeFunctionType())
Pointer = llvm::NoCFIValue::get(cast<llvm::GlobalValue>(Pointer));
}
diff --git a/clang/lib/CodeGen/ItaniumCXXABI.cpp b/clang/lib/CodeGen/ItaniumCXXABI.cpp
index 65c47633bc5c4..3042f37859e5a 100644
--- a/clang/lib/CodeGen/ItaniumCXXABI.cpp
+++ b/clang/lib/CodeGen/ItaniumCXXABI.cpp
@@ -709,7 +709,7 @@ CGCallee ItaniumCXXABI::EmitLoadOfMemberFunctionPointer(
if (BinOp->isPtrMemOp() &&
BinOp->getRHS()
->getType()
- ->hasPointeeToToCFIUncheckedCalleeFunctionType())
+ ->hasPointeeToCFIUncheckedCalleeFunctionType())
ShouldEmitCFICheck = false;
}
}
|
erichkeane
approved these changes
Dec 4, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/19884 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasPointeeToToCFIUncheckedCalleeFunctionType->hasPointeeToCFIUncheckedCalleeFunctionType