[clang-tidy][NFC] Add checks to tests that have no checks specified.

[google-yfyang]

#157306 removes some default checks and this breaks a few tests where no checks were explicitly specified.

[google-yfyang]

@rupprecht Can you take a look?

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: None (google-yfyang)

Changes

#157306 removes some default checks and this breaks a few tests where no checks were explicitly specified.

---

Full diff: https://github.com/llvm/llvm-project/pull/170895.diff

2 Files Affected:

• (modified) clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp (+1-1)
• (modified) clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp (+1-1)

diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
index c4c504c95d475..0331dccd2ce82 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
@@ -1,5 +1,5 @@
 // UNSUPPORTED: system-windows
 
-// RUN: clang-tidy -p %S/Inputs/empty-database %s 2>&1 | FileCheck %s
+// RUN: clang-tidy -checks='-*,clang-analyzer-*' -p %S/Inputs/empty-database %s 2>&1 | FileCheck %s
 
 // CHECK: 'directory' field of compilation database is empty; using the current working directory instead.
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
index 7935385c1a35a..ea9e1029706e2 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
@@ -1,5 +1,5 @@
 // UNSUPPORTED: system-windows
 
-// RUN: not --crash clang-tidy -p %S/Inputs/invalid-database %s 2>&1 | FileCheck %s
+// RUN: not --crash clang-tidy -checks='-*,clang-analyzer-*' -p %S/Inputs/invalid-database %s 2>&1 | FileCheck %s
 
 // CHECK: LLVM ERROR: Cannot chdir into "/invalid/"!

[llvmbot]

@llvm/pr-subscribers-clang-tidy

Author: None (google-yfyang)

Changes

#157306 removes some default checks and this breaks a few tests where no checks were explicitly specified.

---

Full diff: https://github.com/llvm/llvm-project/pull/170895.diff

2 Files Affected:

• (modified) clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp (+1-1)
• (modified) clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp (+1-1)

diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
index c4c504c95d475..0331dccd2ce82 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/empty-database.cpp
@@ -1,5 +1,5 @@
 // UNSUPPORTED: system-windows
 
-// RUN: clang-tidy -p %S/Inputs/empty-database %s 2>&1 | FileCheck %s
+// RUN: clang-tidy -checks='-*,clang-analyzer-*' -p %S/Inputs/empty-database %s 2>&1 | FileCheck %s
 
 // CHECK: 'directory' field of compilation database is empty; using the current working directory instead.
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
index 7935385c1a35a..ea9e1029706e2 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/invalid-database.cpp
@@ -1,5 +1,5 @@
 // UNSUPPORTED: system-windows
 
-// RUN: not --crash clang-tidy -p %S/Inputs/invalid-database %s 2>&1 | FileCheck %s
+// RUN: not --crash clang-tidy -checks='-*,clang-analyzer-*' -p %S/Inputs/invalid-database %s 2>&1 | FileCheck %s
 
 // CHECK: LLVM ERROR: Cannot chdir into "/invalid/"!

[vbvictor]

I'm surprised it didn't break precommit CI, do you have any buildbots that flag this?
Or it fails locally for you?

[google-yfyang]

I'm surprised it didn't break precommit CI, do you have any buildbots that flag this? Or it fails locally for you?

I am not familiar with the precommit CI to know why this isn't triggered. Perhaps these tests are disabled somehow? They fail downstream here in checks at Google.