[libclc] fix clspv/shared/vstore_half.cl #171105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I found that issue building libclc in Google infra, where the build system is not CMake. I am not able to reproduce locally with CMake. It seems that the compiler is able to find a system header with the @wenju-he could you please review ? |
wenju-he
reviewed
Dec 8, 2025
rjodinchr
force-pushed
the
pr/libclc-clspv
branch
from
d986e86 to
498020f
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Update as_type functions
rjodinchr
force-pushed
the
pr/libclc-clspv
branch
from
498020f to
aef7188
Compare
Keenuts
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update as_type functions