Skip to content

Conversation

@kkwli
Copy link
Contributor

@kkwli kkwli commented Jul 31, 2025

llvm_test_traditional() looks for the reference output filename without .cpp.

if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${name}.reference_output.${ENDIAN}-endian.${SIZE_SUFFIX})
set(REFERENCE_OUTPUT ${name}.reference_output.${ENDIAN}-endian.${SIZE_SUFFIX})
elseif(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${name}.reference_output.${SIZE_SUFFIX})
set(REFERENCE_OUTPUT ${name}.reference_output.${SIZE_SUFFIX})
elseif(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${name}.reference_output.${ENDIAN}-endian)
set(REFERENCE_OUTPUT ${name}.reference_output.${ENDIAN}-endian)
elseif(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${name}.reference_output.${TARGET_OS})
set(REFERENCE_OUTPUT ${name}.reference_output.${TARGET_OS})
elseif(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${name}.reference_output)
set(REFERENCE_OUTPUT ${name}.reference_output)
else()
message("-- No reference output found for test ${name}")
endif()

@kkwli kkwli requested a review from fhahn July 31, 2025 22:25
@kkwli kkwli self-assigned this Jul 31, 2025
@kkwli
Copy link
Contributor Author

kkwli commented Aug 11, 2025

@fhahn Ping

@kkwli
Copy link
Contributor Author

kkwli commented Oct 15, 2025

Ping. Any comments are welcome. Thanks.

@tarunprabhu tarunprabhu requested review from asb and lukel97 October 15, 2025 20:45
Copy link
Contributor

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this fix any tests that were failing previously?

@kkwli
Copy link
Contributor Author

kkwli commented Oct 16, 2025

LGTM. Does this fix any tests that were failing previously?

Not that I know of. What happens is that the test is skipped.

Thanks for the review.

@kkwli kkwli merged commit 549863a into llvm:main Oct 16, 2025
1 check passed
@kkwli kkwli deleted the rename-output-file branch October 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants