[HIP] Increase blender perf diff threshold #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter sets how much difference in runtime the blender workloads are allowed to show when run in the testing. In reality it was advised to set this to 15% instead of the 5% shown here. With this patch, we increase the default threshold to 10% to see if this gives us enough wiggle room out of the box to not see any runtime related flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter sets how much difference in runtime the blender workloads are allowed to show when run in the testing.
In reality it was advised to set this to 15% instead of the 5% shown here.
With this patch, we increase the default threshold to 10% to see if this gives us enough wiggle room out of the box to not see any runtime related flakiness.