Set up Vulkan compute in mlir-nvidia docker #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
changed the title
This commit changes the mlir-nvidia docker to additionally install Vulkan SDK. NVIDIA's Vulkan ICD is already installed as part of the CUDA meta package.
antiagainst
force-pushed
the
vulkan-docker
branch
from
d6c3b7e to
706905e
Compare
|
Hello Lei, We do not use/accept github pull requests at this moment. This is a common LLVM policy. Could you remove this PR and submit your patch at http://reviews.llvm.org, please? |
|
This was already merged via my change #4 --> closing it As a personal comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the mlir-nvidia docker to additionally install
Vulkan SDK. NVIDIA's Vulkan ICD is already installed as part of
the CUDA meta package.
Also enables running Vulkan tests in mlir-nvidia build workers.