[AMDGPU][libc] Disallow collapsing of requests #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen on this bot in particular issues with picking up a breaking change and some NFC change. This leads to the bot not commenting on the PR.
Member
|
Are you sure a single worker able to keep up with the workload? I've seen a builder lagging behind 3 months because it was slower processing commits than there were new ones. |
Contributor
Author
|
I would like to give it a shot. I monitor those workers relatively closely and we can revert this change or move the bot to another machine when we see that it starts lagging (too much). |
Meinersbur
approved these changes
Dec 9, 2024
Contributor
Author
|
@gkistanova this bot is in production, so I believe we need a master restart. This is not urgent. Let me know if you need anything from our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen on this bot in particular issues with picking up a breaking change and some NFC change. This leads to the bot not commenting on the PR.