Update lldb jobs to run on arm 64 machines #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael137
reviewed
Mar 26, 2025
| } | ||
| environment { | ||
| MATRIX_COMMON_BUILD_PARAMETERS = '--cmake-flag=-DLLVM_TARGETS_TO_BUILD=X86' | ||
| MATRIX_COMMON_BUILD_PARAMETERS = '--cmake-flag=-DLLVM_TARGETS_TO_BUILD=AArch64' |
Member
There was a problem hiding this comment.
Hmm I think we want this to be X86;AArch64
Only specifying one of them means we wouldn't run some of the x86 tests on ARM machine and vice-versa. But we do want that test-coverage. They don't actually require an x86 host
Michael137
approved these changes
Mar 26, 2025
Member
Michael137
left a comment
Michael137
left a comment
There was a problem hiding this comment.
🚢
Thanks!
Just minor comment re. CMake change
| --cmake-type=Release \ | ||
| --dotest-flag="--skip-category gmodules" \ | ||
| --dotest-flag="--arch=x86_64" | ||
| --dotest-flag="--arch=aarch64" |
Contributor
There was a problem hiding this comment.
This may work, but it would be safer to use arm64 for all the --arch parameters passed to dotest.
Contributor
|
LGTM with the discussed changes. Let's try it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lldb-matrix and lldb-sanitized to run on apple SI machines