[libc][AMDGPU] Add libc to the runtimes list #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that if something is contained in the `depends_on_project` list but is not explicitly mentioned as an `enable_runtimes`, while also an explicit `enable_runtimes` list is passed to the unified tree builder, that component is auto-added as an `LLVM_ENABLE_PROJECTS`. This is wrong in the case of libc. Wile we only care about the version being built for AMDGPU, this appears to be the easiest fix to unblock our libc bot.
Contributor
Author
|
@gkistanova I believe the bot in question is in production. I'd appreciate if we can propagate this to prod, once landed. |
jhuber6
approved these changes
Mar 31, 2025
Contributor
|
This change has been applied to production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that if something is contained in the
depends_on_projectlist but is not explicitly mentioned as anenable_runtimes, while also an explicitenable_runtimeslist is passed to the unified tree builder, that component is auto-added as anLLVM_ENABLE_PROJECTS. This is wrong in the case of libc.Wile we only care about the version being built for AMDGPU, this appears to be the easiest fix to unblock our libc bot.