Pass op legality info to verifyBackendContractPass #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to verify if a given IR satisfies the backend contract, the verifier needs to know if decompositions took place, and if so, which ops were decomposed and which were not. This commit adds two arguments to `verifyBackendContractPass` to specify if decompositions took place and which ops to consider backend legal, similar to the arguments of `LowerToBackendContractPass`.
ramiro050
force-pushed
the
verify-backend
branch
from
802ff07 to
d8d5fa0
Compare
silvasean
approved these changes
Dec 15, 2022
Contributor
silvasean
left a comment
silvasean
left a comment
There was a problem hiding this comment.
Thanks!
nit: Remove WIP from final commit title.
ramiro050
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to verify if a given IR satisfies the backend contract, the verifier needs to know if decompositions took place, and if so, which ops were decomposed and which were not.
This commit adds two arguments to
verifyBackendContractPassto specify if decompositions took place and which ops to consider backend legal, similar to the arguments ofLowerToBackendContractPass.