Skip to content

Conversation

@Max191
Copy link
Contributor

@Max191 Max191 commented Oct 25, 2024

@Max191
Copy link
Contributor Author

Max191 commented Oct 25, 2024

Waiting for a stablehlo llvm integrate to land, and then I will bump stablehlo in this PR.

EDIT: This is done

@Max191 Max191 force-pushed the integrates/llvm-20241024 branch 2 times, most recently from 5583213 to 6870f23 Compare October 25, 2024 21:06
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
@Max191 Max191 force-pushed the integrates/llvm-20241024 branch from 6870f23 to d139d14 Compare October 30, 2024 13:36
@Max191 Max191 marked this pull request as ready for review October 30, 2024 14:13
@Max191 Max191 requested review from mgehre-amd, pashu123, ramiro050, rsuderman and vivekkhandelwal1 and removed request for mgehre-amd and rsuderman October 30, 2024 14:14
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you please add a one-line description in the commit message corresponding to the optional value change?

@Max191 Max191 merged commit 8b0bf2e into llvm:main Oct 30, 2024
3 checks passed
rahuls-cerebras added a commit that referenced this pull request Jan 3, 2025
TimAtGoogle pushed a commit that referenced this pull request Feb 12, 2025
- bumps llvm-project to
llvm/llvm-project@6c64c8a
- bumps stablehlo to
openxla/stablehlo@6e403b1
- Updates type conversion materialization functions to return Value
after API change in llvm-project.

---------

Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants