Remove variable used for only assertion #3837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
force-pushed
the
remove-unused-var
branch
from
268a085 to
1507293
Compare
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Max191
force-pushed
the
remove-unused-var
branch
from
1507293 to
76e57d6
Compare
JOE1994
approved these changes
Oct 30, 2024
zjgarvey
approved these changes
Oct 30, 2024
rahuls-cerebras
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit 6b58c89.
TimAtGoogle
pushed a commit
that referenced
this pull request
Feb 12, 2025
Removes a boolean variable that is used only for an assertion, and inlines the condition into the assertion. Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a boolean variable that is used only for an assertion, and inlines the condition into the assertion.