[e2e] : Change default to fx_importer. #4387
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjarus
approved these changes
Nov 24, 2025
Contributor
hariprasadravi
left a comment
hariprasadravi
left a comment
There was a problem hiding this comment.
Thanks for addressing this quickly!
| "--config", | ||
| choices=config_choices, | ||
| default="linalg", | ||
| default="fx_importer", |
Contributor
There was a problem hiding this comment.
Ideally, this should have been named fx_importer_linalg to make it consistent with fx_importer_tosa and stablehlo. Will it be very invasive?
Member
Author
There was a problem hiding this comment.
AFAIK, tosa/stablehlo paths were introduced after the linalg backend path. So that's probably why the names are the way they are currently. I think changing fx_importer to fx_importer_linalg may cause issues for downstream users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since torchscript path is not maintained anymore, updating the default choice for e2e testing to
fx_importerfromlinalg. Backend being tested is still thelinalgpath.Fixes #4386