[tosa] Enable tosa-to-linalg-named so Matmul works again #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Sudhir <suraj.sudhir@arm.com>
Collaborator
Author
|
There's a new pass tosa-to-linalg-named into which tosa.matmul (as well as conv, etc) have been moved. This was not being called earlier, which is why all the matmul tests broke when LLVM was updated. |
cathyzhyi
approved these changes
Jan 19, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* Simplify recursion Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Use plain type Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Using template Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Some special cases do not need computing access indices Signed-off-by: Tung D. Le <tung@jp.ibm.com> * revise Signed-off-by: Tung D. Le <tung@jp.ibm.com> * clang-format Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Change function names Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Edit comments Signed-off-by: Tung D. Le <tung@jp.ibm.com> * use reshape for unsqueeze Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Manually allocate memory and use external files Signed-off-by: Tung D. Le <tung@jp.ibm.com> * comments Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Undo cmake Signed-off-by: Tung D. Le <tung@jp.ibm.com> * use stdlib Signed-off-by: Tung D. Le <tung@jp.ibm.com> * format Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Use double and int64_t in computation to avoid the precious loss Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Minor changes Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Simplify some code Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Not using attribute in splitop Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Revise checking dense constants Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Remove all temporary files at the end of constprop Signed-off-by: Tung D. Le <tung@jp.ibm.com> * A flag to switch between using file and heap Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Use memory only Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Add comment Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Explaination about the use of buffers Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Clean up includes Signed-off-by: Tung D. Le <tung@jp.ibm.com> Co-authored-by: Kevin O'Brien <caomhin@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Sudhir suraj.sudhir@arm.com