[TORCH][MLIR] Add run-time assert support in Torch-dialect #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzhyi
requested changes
Feb 8, 2022
Contributor
cathyzhyi
left a comment
cathyzhyi
left a comment
There was a problem hiding this comment.
Thanks for the change! The code looks good to me. Just need more comments and some adjustment to naming.
- This commit adds `aten.assert` op in the Torch dialect. - The `aten.assert` op is lowered to `mlir::Assert` op. Signed-Off-by: Gaurav Shukla <gaurav@nod-labs.com>
Shukla-Gaurav
force-pushed
the
gaurav/assert
branch
from
2ffe5bb to
a968e02
Compare
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Updating pybind11 submodule from a level not matching any particular release to one matching the latest release: v2.6.2. Signed-off-by: Steven Royer <seroyer@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aten.assertop in the Torch dialect.aten.assertop is lowered tomlir::Assertop.Signed-Off-by: Gaurav Shukla gaurav@nod-labs.com