🐛 fix: fix file upload issue

[arvinxx]

💻 Change Type

• ✨ feat
• 🐛 fix
• ♻️ refactor
• 💄 style
• 👷 build
• ⚡️ perf
• ✅ test
• 📝 docs
• 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

• Tested locally
• Added/updated tests
• No tests needed

📸 Screenshots / Videos

Before	After
...	...

📝 Additional Information

Summary by Sourcery

Bug Fixes:

• Fallback to the client-provided file size when remote metadata cannot be fetched and reject uploads smaller than one byte.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Ready	Preview, Comment	Jan 3, 2026 5:08am

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gru-agent]

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	b7acb1c	✅ Finished

History Assignment

Files

File	Pull Request
src/server/routers/lambda/file.ts	❌ Failed (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts file upload size determination to fall back gracefully when metadata lookup fails and enforces a minimum file size of 1 byte before creating the file record.

Sequence diagram for updated file upload size determination

sequenceDiagram
  participant Client
  participant FileRouter
  participant FileService
  participant FileModel

  Client->>FileRouter: uploadFile(url, size)
  FileRouter->>FileService: getFileMetadata(url)
  alt metadata lookup succeeds
    FileService-->>FileRouter: contentLength
    alt contentLength >= 1
      FileRouter->>FileRouter: actualSize = contentLength
    else contentLength < 1
      FileRouter->>FileRouter: actualSize = input size
    end
  else metadata lookup fails
    FileService-->>FileRouter: error
    FileRouter->>FileRouter: actualSize = input size
  end

  alt actualSize < 1
    FileRouter-->>Client: TRPCError BAD_REQUEST
  else actualSize >= 1
    FileRouter->>FileModel: create(fileRecord with actualSize)
    FileModel-->>FileRouter: created file id
    FileRouter-->>Client: success with file id
  end

Loading

Class diagram for file upload router and services

classDiagram
  class FileRouter {
    +uploadFile(url, size)
  }

  class FileService {
    +getFileMetadata(url) contentLength
  }

  class FileModel {
    +create(fileRecord) id
  }

  FileRouter --> FileService : uses
  FileRouter --> FileModel : creates fileRecord

Loading

File-Level Changes

Change	Details	Files
Make file size determination more robust and enforce a minimum file size when handling uploads.	Initialize actual file size from the client-provided input size before attempting metadata lookup. Wrap file metadata retrieval in a try/catch block so failures fall back to the provided size instead of breaking the upload flow. Only override the initial size when the fetched content length is at least 1 byte. Validate the final resolved size and reject uploads with a size less than 1 byte using a BAD_REQUEST TRPC error.	src/server/routers/lambda/file.ts

Possibly linked issues

• #(not provided): PR changes file size detection and validation, preventing legitimate uploads from being treated as empty, matching the reported error
• #N/A: PR adjusts file size detection and validation in upload flow, likely fixing uploads that hang indefinitely as in issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The silent catch around getFileMetadata makes it hard to debug metadata failures; consider at least logging or tagging the error path so operators can distinguish genuine tiny files from metadata lookup issues.
• The fallback to input.size assumes it is always defined and trustworthy; if this comes from the client, consider validating it (e.g., non-negative, reasonable upper bound) or making the type/constraints explicit to avoid abuse.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The silent catch around `getFileMetadata` makes it hard to debug metadata failures; consider at least logging or tagging the error path so operators can distinguish genuine tiny files from metadata lookup issues.
- The fallback to `input.size` assumes it is always defined and trustworthy; if this comes from the client, consider validating it (e.g., non-negative, reasonable upper bound) or making the type/constraints explicit to avoid abuse.

## Individual Comments

### Comment 1
<location> `src/server/routers/lambda/file.ts:73-74` </location>
<code_context>
+        if (contentLength >= 1) {
+          actualSize = contentLength;
+        }
+      } catch {
+        // If metadata fetch fails, use original size from input
+      }
+
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Empty catch may hide unexpected failures in metadata lookup

Swallowing all exceptions here means configuration, permission, or `fileService` outages will be silently masked by falling back to `input.size`, which may be wrong and hard to diagnose. Please either log failures (e.g., debug/warn) or restrict the catch to the specific, expected error types so operational issues remain visible without changing user-facing behavior.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Empty catch may hide unexpected failures in metadata lookup

Swallowing all exceptions here means configuration, permission, or fileService outages will be silently masked by falling back to input.size, which may be wrong and hard to diagnose. Please either log failures (e.g., debug/warn) or restrict the catch to the specific, expected error types so operational issues remain visible without changing user-facing behavior.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.60%. Comparing base (885964e) to head (e045f37).
⚠️ Report is 10 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff            @@
##             next   #11122    +/-   ##
========================================
  Coverage   77.59%   77.60%            
========================================
  Files        1120     1120            
  Lines       84379    84404    +25     
  Branches    11191    10781   -410     
========================================
+ Hits        65476    65503    +27     
+ Misses      18903    18901     -2     

Flag	Coverage Δ
app	70.37% <100.00%> (+0.01%)	⬆️
database	94.35% <ø> (ø)
packages/agent-runtime	90.26% <ø> (ø)
packages/context-engine	86.44% <ø> (ø)
packages/conversation-flow	95.79% <ø> (ø)
packages/electron-server-ipc	93.76% <ø> (ø)
packages/file-loaders	92.20% <ø> (ø)
packages/model-bank	100.00% <ø> (ø)
packages/model-runtime	89.75% <ø> (ø)
packages/prompts	77.55% <ø> (ø)
packages/python-interpreter	96.50% <ø> (ø)
packages/utils	89.43% <ø> (ø)
packages/web-crawler	96.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	69.72% <ø> (ø)
Services	52.54% <ø> (ø)
Server	73.28% <100.00%> (+0.01%)	⬆️
Libs	41.77% <ø> (ø)
Utils	93.03% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lobehubbot]

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

[lobehubbot]

🎉 This PR is included in version 2.0.0-next.197 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀