74: Handle persistent store directory change with v1 release #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
requested changes
Dec 5, 2022
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot for jumping on this so fast, @confusedpublic!
I just found some minor things that should be changed, afterwards we're good to merge and release a new version! 🚀
Co-authored-by: Alexander Rashed <2796604+alexrashed@users.noreply.github.com>
Co-authored-by: Alexander Rashed <2796604+alexrashed@users.noreply.github.com>
Contributor
Author
|
Thanks for those suggestions @alexrashed. I've committed the suggestions :) |
alexrashed
requested changes
Dec 6, 2022
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for the changes! There's just one small issue left, then we're good to merge it :)
alexrashed
approved these changes
Dec 7, 2022
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
I just quickly removed the line in a short commit, now we're ready to merge (and release)!
Again, thanks for the contribution, @confusedpublic! 🚀
Contributor
Author
|
Thanks for sorting that out, @alexrashed 😄 |
confusedpublic
deleted the
fix/71/handle-persistent-storage-localstack-v1.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71
To resolve the above issue, I could have either:
mountPathto be what is expected by versions of localstack >= 1.0.0I've decided to implement a backwards compatible fix, however if the maintainers would prefer to only handle the >= 1.0.0 path, I will remove the conditional logic and update the
mountPathto just be/var/lib/localstackTested locally by varying the values for
--set image.tagtolatest,1.2.0and0.14.5- the chart deploys successfully with all values.