Skip to content

Update image fix #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Update image fix #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
139af5b
Fixed issue of listing subset of images
Pive01 Jun 8, 2023
90bbf83
added more filter
Pive01 Jun 8, 2023
51d86c4
Merge branch 'main' into update-image-fix
Pive01 Jun 16, 2023
9b36b46
Merge branch 'main' into update-image-fix
Pive01 Aug 25, 2023
245290c
bumped up version
Pive01 Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
IMAGE?=localstack/localstack-docker-desktop
TAG?=0.4.1
TAG?=0.4.2

BUILDER=buildx-multi-arch

Expand Down
13 changes: 12 additions & 1 deletion ui/src/components/Header/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ import { UpdateDialog } from '../Views';

const ITEM_HEIGHT = 80;

const IMAGE_PREFIXES = [
'localstack/',
'lambci/lambda:',
'mlupin/docker-lambda:',
'public.ecr.aws/lambda',
];


export const LongMenu = () => {
const [anchorEl, setAnchorEl] = useState<null | HTMLElement>(null);
const [openModal, setOpenModal] = useState<boolean>(false);
Expand All @@ -34,7 +42,10 @@ export const LongMenu = () => {
const fetchImages = async () => {
const images = (await ddClient.docker.listImages()) as DockerImage[];

const localstackImages = images.filter(image => image.RepoTags?.at(0)?.startsWith('localstack/'));
const localstackImages = images.filter(image =>
IMAGE_PREFIXES.some(prefix => image.RepoTags?.at(0)?.startsWith(prefix)) &&
!image.RepoTags?.at(0)?.endsWith(':<none>'));

const imagesWithoutOrgName = localstackImages.map(image => removeRepoFromImage(image.RepoTags?.at(0)));
setImages(imagesWithoutOrgName);
};
Expand Down