Skip to content

Conversation

abhirajadhikary06
Copy link
Contributor

@abhirajadhikary06 abhirajadhikary06 commented Oct 7, 2025

Closes #219
I have added the required things in the documentation of elb-load-balancing:

  • Updated Introduction
  • Architecture and Diagram
  • Testing the application with ELB DNS curl checks.
  • Updated Conclusion

Now all 6 sections are present perfectly.

[x]I agree to follow this project's Code of Conduct

Architecture Diagram that is added to the context:
elb-load-balancing-architecture-image

@abhirajadhikary06
Copy link
Contributor Author

@remotesynth @quetzalliwrites @blkgrlcto Please have a check at the PR.

@abhirajadhikary06
Copy link
Contributor Author

@blkgrlcto please put this PR under review

@quetzalliwrites quetzalliwrites added documentation Improvements or additions to documentation hacktoberfest labels Oct 13, 2025
@quetzalliwrites
Copy link
Collaborator

Thank you for your contribution, @abhirajadhikary06! 🤝

We appreciate your patience as the team takes the time to review the many HacktoberFest PRs that came through! Also some folks were on holiday.

- Lambda Functions: Handle business logic (e.g., return "Hello 1").
- VPC/Subnet: Provides network boundaries.

![Architecture diagram for ELB Application Load Balancer with Lambda targets](/src/assets/images/aws/tutorials/elb-load-balancing-architecture-image.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @abhirajadhikary06, that's a neat diagram! Love it.

The only thing is that I would like all diagrams added to the docs be consistent in look/feel.

Let me ask the team their thoughts too :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me know if any updates are required.

@quetzalliwrites
Copy link
Collaborator

@blkgrlcto @remotesynth Hola team, quick Q about the diagrams. Since we want them to be consistent... how do we feel about asking all docs contributors to make all diagrams as Mermaid.JS syntax?

Copy link
Collaborator

@remotesynth remotesynth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the diagram but understand @quetzalliwrites concern around consistency. However, I feel like this doesn't need to be a blocker here for the contribution and we can update the diagrams across the board for consistency in the future.

@remotesynth remotesynth merged commit 23af917 into localstack:main Oct 16, 2025
@blkgrlcto
Copy link

Hi @abhirajadhikary06. Thanks so much for your HacktoberFest contribution! Now that your PR has been merged, go ahead and fill out this form to claim your swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Normalize structure: Elastic Load Balancer with LocalStack

4 participants