-
Notifications
You must be signed in to change notification settings - Fork 16
Updated documentation for elb-load-balancing #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation for elb-load-balancing #267
Conversation
@remotesynth @quetzalliwrites @blkgrlcto Please have a check at the PR. |
@blkgrlcto please put this PR under review |
Thank you for your contribution, @abhirajadhikary06! 🤝 We appreciate your patience as the team takes the time to review the many HacktoberFest PRs that came through! Also some folks were on holiday. |
- Lambda Functions: Handle business logic (e.g., return "Hello 1"). | ||
- VPC/Subnet: Provides network boundaries. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow @abhirajadhikary06, that's a neat diagram! Love it.
The only thing is that I would like all diagrams added to the docs be consistent in look/feel.
Let me ask the team their thoughts too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me know if any updates are required.
@blkgrlcto @remotesynth Hola team, quick Q about the diagrams. Since we want them to be consistent... how do we feel about asking all docs contributors to make all diagrams as Mermaid.JS syntax? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the diagram but understand @quetzalliwrites concern around consistency. However, I feel like this doesn't need to be a blocker here for the contribution and we can update the diagrams across the board for consistency in the future.
Hi @abhirajadhikary06. Thanks so much for your HacktoberFest contribution! Now that your PR has been merged, go ahead and fill out this form to claim your swag. |
Closes #219
I have added the required things in the documentation of elb-load-balancing:
curl
checks.Now all 6 sections are present perfectly.
[x]I agree to follow this project's Code of Conduct
Architecture Diagram that is added to the context:
