Does v3 is supported also on react-native v0.77? #218
Replies: 5 comments 16 replies
-
|
@oferRounds hey! thank you for testing it out. Can you please provide a repro that I can checkout? Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
I just updated example to load 200 items in a scrollview with images/text. it takes few ms (dev mode) to open but content is sure there. |
Beta Was this translation helpful? Give feedback.
-
|
@lodev09 sorry for my delay! And amazing work with v3.0 release! have you tired to build it with rn 0.77? I think it will be easily reproduce there. I also noticed that with your latest change, it does not get build with 0.77 (with the attached error). I was able to patch the library, and fixed the yoga error, but the problem still remains (was working on v2) true_sheet.mp4
|
Beta Was this translation helpful? Give feedback.
-
|
Thank you @lodev09!
Regarding the upgrade – I wish we could upgrade, we currently dependant on react-native-navigation, which does not yet support higher RN versions |
Beta Was this translation helpful? Give feedback.
-
|
@lodev09 any idea if one of the latest fixes on the repo might solve the issue? |
Beta Was this translation helpful? Give feedback.



Uh oh!
There was an error while loading. Please reload this page.
-
I know this RN version is not supported, this why I open my question-issue here. Feel free to close it if you feel it’s not relevant based on our RN version
Bottom sheet shows empty content on every presentation in v3.0.0-beta.2
Description
After upgrading from
react-native-true-sheetv2 to v3.0.0-beta.2, bottom sheets exhibit the following behavior:Environment
@lodev09/react-native-true-sheet: 3.0.0-beta.3newArchEnabled=true)['auto'],['auto', 'large'](issue may occur with other detent configurations as well)Root Cause Analysis
The issue appears to be related to v3's lazy loading mechanism:
When
present()is called, the sheet uses lazy loading:shouldRenderNativeView: trueonMounteventTrueSheetModule.presentByRef()The timing between when the native module presents the sheet and when the content is actually rendered/measured appears to be misaligned, resulting in:
After dismissal,
onDidDismisssetsshouldRenderNativeView: false(line 228 in TrueSheet.tsx), destroying the native view and causing the issue to repeat on every subsequent present.Expected Behavior
The sheet should present with its content visible on every
present()call, just like in v2.Actual Behavior
Minimal Reproduction
import { useRef } from 'react';
import { View, Button, Text } from 'react-native';
import { TrueSheet } from '@lodev09/react-native-true-sheet';
export default function App() {
const sheet = useRef(null);
return (
<View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
<Button title="Open Sheet" onPress={() => sheet.current?.present()} />
);
}### Notes
autodetent, but may also occur with other detent configurationsSuggested Fix
The lazy loading mechanism needs to ensure that:
presentByRef()is calledAdditional Context
This issue makes v3 unusable for apps migrating from v2, as the bottom sheet content is never visible. The lazy loading optimization appears to have broken the core functionality of displaying content in the sheet.
Beta Was this translation helpful? Give feedback.
All reactions