Skip to content

Conversation

@richardhinkamp
Copy link
Contributor

Make shutdown consistent:

  • cb is optional in both function definitions
  • cb can get undefined as arg when no error occured
  • with no shutdown functions, return null instead of the return value of cb(), like the return value with shutdown functions.
  • with no shutdown functions, explicit pass of undefined to cb() for simpler typings of cb() to always have an argument.

@lamweili lamweili added this to the 6.7.0 milestone Sep 2, 2022
@lamweili lamweili merged commit 6a60294 into log4js-node:master Sep 2, 2022
lamweili added a commit that referenced this pull request Sep 3, 2022
refactor(#1082): removed return value for `log4js.shutdown()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants