Skip to content

Conversation

@nomiddlename
Copy link
Collaborator

Travis CI stopped working for open source builds a long time ago. This PR adds a github action to do the build.

@lamweili lamweili added this to the 3.0.0 milestone Jan 10, 2022
@lamweili lamweili force-pushed the gh-action-build branch 2 times, most recently from 1049b3a to 79cdb48 Compare January 10, 2022 18:55
@lamweili
Copy link
Contributor

lamweili commented Jan 10, 2022

  1. CI on Windows is failing because it didn't reach 100% coverage, namely due to the exclusion below:

    // in windows, you can't delete a directory if there is an open file handle
    if (process.platform !== "win32") {
    describe("when the directory gets deleted", function() {
    var stream;

  2. Not exactly sure why CI on Windows will sometimes cancel themselves.

  3. The fs.ensureDir (instead of fs.ensureFile) is deliberate (since 17731e1) for RollingFileWriteStream.js:267 test coverage. Maybe should add a comment.

    before(done => {
    fs.ensureDir(path.join(__dirname, "tmp-delete-test/logfile.log.2"), done);
    });

    const deleteFiles = fileNames => {
    debug(`deleteFiles: files to delete: ${fileNames}`);
    return Promise.all(fileNames.map(f => fs.unlink(f).catch((e) => {
    debug(`deleteFiles: error when unlinking ${f}, ignoring. Error was ${e}`);
    })));
    };

@nomiddlename nomiddlename merged commit a25215c into master Jan 10, 2022
@nomiddlename nomiddlename deleted the gh-action-build branch January 10, 2022 22:21
@lamweili lamweili removed this from the 3.0.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants