Skip to content

Conversation

@moritzmeister
Copy link
Contributor

  • add online_enabled to external feature group
  • move online_enabled to base fg
  • new attempt
  • move expectation suite engine to base class
  • fix base fg init
  • ext feature group has no stream flag
  • fix spark engine for stream flag
  • fix expectation suite init
  • move avro logic to base class
  • move subject
  • try something
  • move more stuff to base engine
  • try
  • online topic name has to be set
  • fix online topic name

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@moritzmeister moritzmeister merged commit 7a934e2 into logicalclocks:master Apr 4, 2023
@moritzmeister moritzmeister deleted the FSTORE-743 branch April 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants