Skip to content

[FSTORE-1160] Remove wait_for_job in all tutorials #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 12, 2024
Merged

[FSTORE-1160] Remove wait_for_job in all tutorials #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0155fd9
Churn
Maxxx-zh Feb 7, 2024
2717a2f
Fraud_batch
Maxxx-zh Feb 7, 2024
eebcb84
Fraud_Online
Maxxx-zh Feb 7, 2024
1bbf79d
Loan_Approval
Maxxx-zh Feb 7, 2024
50b0b15
Air_Quality
Maxxx-zh Feb 7, 2024
7d5dc78
Bitcoin
Maxxx-zh Feb 7, 2024
b50b895
Citibike
Maxxx-zh Feb 7, 2024
afed433
CreditScores
Maxxx-zh Feb 7, 2024
dfccf5a
Electricity
Maxxx-zh Feb 7, 2024
1f91877
Nyc_taxi_fares
Maxxx-zh Feb 7, 2024
00e24dd
RecSys
Maxxx-zh Feb 7, 2024
6522170
Transformation Functions
Maxxx-zh Feb 7, 2024
56b4c7e
Fraud Batch
Maxxx-zh Feb 7, 2024
3051404
Churn
Maxxx-zh Feb 7, 2024
e74d17b
Fraud Online
Maxxx-zh Feb 7, 2024
3f21d28
Iris
Maxxx-zh Feb 7, 2024
c0a2c30
Quickstart
Maxxx-zh Feb 7, 2024
8e45093
federated-offline-query tutorial
Maxxx-zh Feb 9, 2024
f856ec9
Monitoring tutorial
Maxxx-zh Feb 9, 2024
28d9021
wandb tutorial
Maxxx-zh Feb 9, 2024
ac6d491
RecSys wait_for_job
Maxxx-zh Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions advanced_tutorials/air_quality/1_air_quality_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,10 +626,7 @@
"outputs": [],
"source": [
"# Insert data\n",
"weather_fg.insert(\n",
" df_weather, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"weather_fg.insert(df_weather)"
]
},
{
Expand Down
7 changes: 2 additions & 5 deletions advanced_tutorials/bitcoin/1_bitcoin_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,7 @@
" event_time='unix',\n",
")\n",
"\n",
"tweets_vader_fg.insert(\n",
" tweets_vader,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"tweets_vader_fg.insert(tweets_vader)"
]
},
{
Expand Down Expand Up @@ -417,7 +414,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.12"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
4 changes: 2 additions & 2 deletions advanced_tutorials/bitcoin/2_bitcoin_feature_pipeline.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@
"metadata": {},
"outputs": [],
"source": [
"tweets_vader_fg.insert(tweets_vader_batch, wait=True)"
"tweets_vader_fg.insert(tweets_vader_batch)"
]
},
{
Expand Down Expand Up @@ -536,7 +536,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.12"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
22 changes: 5 additions & 17 deletions advanced_tutorials/citibike/1_citibike_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,10 +514,7 @@
},
"outputs": [],
"source": [
"citibike_usage_fg.insert(\n",
" df_enhanced,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"citibike_usage_fg.insert(df_enhanced)"
]
},
{
Expand Down Expand Up @@ -546,10 +543,7 @@
},
"outputs": [],
"source": [
"citibike_stations_info_fg.insert(\n",
" df_stations_info,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"citibike_stations_info_fg.insert(df_stations_info)"
]
},
{
Expand All @@ -575,10 +569,7 @@
"metadata": {},
"outputs": [],
"source": [
"us_holidays_fg.insert(\n",
" df_holidays,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"us_holidays_fg.insert(df_holidays)"
]
},
{
Expand Down Expand Up @@ -606,10 +597,7 @@
},
"outputs": [],
"source": [
"meteorological_measurements_fg.insert(\n",
" df_weather, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"meteorological_measurements_fg.insert(df_weather)"
]
},
{
Expand Down Expand Up @@ -643,7 +631,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.12"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
5 changes: 1 addition & 4 deletions advanced_tutorials/citibike/2_citibike_feature_pipeline.ipynb
View file
Open in desktop
Copy link
Collaborator

@manu-sj manu-sj Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just something I noticed while testing is that this tutorial does not work with master but works in app.

Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,7 @@
"outputs": [],
"source": [
"# Insert new data\n",
"meteorological_measurements_fg.insert(\n",
" df_weather_batch,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"meteorological_measurements_fg.insert(df_weather_batch)"
]
},
{
Expand Down
37 changes: 8 additions & 29 deletions advanced_tutorials/credit_scores/1_credit_scores_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,10 +433,7 @@
" online_enabled=False,\n",
" event_time='datetime',\n",
")\n",
"applications_fg.insert(\n",
" applications_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"applications_fg.insert(applications_df)"
]
},
{
Expand All @@ -460,10 +457,7 @@
" primary_key=['sk_id_bureau'],\n",
" online_enabled=False,\n",
")\n",
"bureau_balances_fg.insert(\n",
" bureau_balances_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"bureau_balances_fg.insert(bureau_balances_df)"
]
},
{
Expand All @@ -488,10 +482,7 @@
" online_enabled=False,\n",
" event_time='datetime',\n",
")\n",
"bureaus_fg.insert(\n",
" bureaus_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"bureaus_fg.insert(bureaus_df)"
]
},
{
Expand All @@ -516,10 +507,7 @@
" online_enabled=False,\n",
" event_time='datetime',\n",
")\n",
"previous_applications_fg.insert(\n",
" previous_applications_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"previous_applications_fg.insert(previous_applications_df)"
]
},
{
Expand Down Expand Up @@ -571,10 +559,7 @@
" online_enabled=False,\n",
" event_time='datetime',\n",
")\n",
"installment_payments_fg.insert(\n",
" installment_payments_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"installment_payments_fg.insert(installment_payments_df)"
]
},
{
Expand All @@ -598,10 +583,7 @@
" primary_key=['sk_id_prev','sk_id_curr'],\n",
" online_enabled=False,\n",
")\n",
"credit_card_balances_fg.insert(\n",
" credit_card_balances_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"credit_card_balances_fg.insert(credit_card_balances_df)"
]
},
{
Expand All @@ -626,10 +608,7 @@
" online_enabled=False,\n",
")\n",
"\n",
"previous_loan_counts_fg.insert(\n",
" previous_loan_counts,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"previous_loan_counts_fg.insert(previous_loan_counts)"
]
},
{
Expand Down Expand Up @@ -908,7 +887,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.12"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
30 changes: 9 additions & 21 deletions advanced_tutorials/credit_scores/2_credit_scores_feature_pipeline.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,7 @@
"metadata": {},
"outputs": [],
"source": [
"bureau_balances_fg.insert(\n",
" bureau_balances_df_generated,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"bureau_balances_fg.insert(bureau_balances_df_generated)"
]
},
{
Expand All @@ -410,10 +407,7 @@
"metadata": {},
"outputs": [],
"source": [
"bureaus_fg.insert(\n",
" bureaus_df_generated, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"bureaus_fg.insert(bureaus_df_generated)"
]
},
{
Expand All @@ -423,10 +417,7 @@
"metadata": {},
"outputs": [],
"source": [
"credit_card_balances_fg.insert(\n",
" credit_card_balances_df_generated,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"credit_card_balances_fg.insert(credit_card_balances_df_generated)"
]
},
{
Expand All @@ -436,7 +427,10 @@
"metadata": {},
"outputs": [],
"source": [
"installment_payments_fg.insert(installment_payments_df_generated)"
"installment_payments_fg.insert(\n",
" installment_payments_df_generated,\n",
" write_options={\"wait_for_job\": True},\n",
")"
]
},
{
Expand All @@ -446,10 +440,7 @@
"metadata": {},
"outputs": [],
"source": [
"pos_cash_balances_fg.insert(\n",
" pos_cash_balances_df_generated,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"pos_cash_balances_fg.insert(pos_cash_balances_df_generated)"
]
},
{
Expand All @@ -469,10 +460,7 @@
"metadata": {},
"outputs": [],
"source": [
"previous_loan_counts_fg.insert(\n",
" previous_loan_counts_df_generated,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"previous_loan_counts_fg.insert(previous_loan_counts_df_generated)"
]
},
{
Expand Down
17 changes: 4 additions & 13 deletions advanced_tutorials/electricity/1_electricity_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,7 @@
},
"outputs": [],
"source": [
"meteorological_measurements_fg.insert(\n",
" meteorological_measurements_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"meteorological_measurements_fg.insert(meteorological_measurements_df)"
]
},
{
Expand Down Expand Up @@ -309,10 +306,7 @@
},
"outputs": [],
"source": [
"electricity_prices_fg.insert(\n",
" electricity_prices_df,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"electricity_prices_fg.insert(electricity_prices_df)"
]
},
{
Expand Down Expand Up @@ -342,10 +336,7 @@
},
"outputs": [],
"source": [
"swedish_holidays_fg.insert(\n",
" holidays_df, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"swedish_holidays_fg.insert(holidays_df)"
]
},
{
Expand Down Expand Up @@ -382,7 +373,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.12"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
5 changes: 1 addition & 4 deletions advanced_tutorials/electricity/2_electricity_feature_pipeline.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,7 @@
"outputs": [],
"source": [
"# Insert data\n",
"electricity_prices_fg.insert(\n",
" electricity_prices_df, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"electricity_prices_fg.insert(electricity_prices_df)"
]
},
{
Expand Down
10 changes: 2 additions & 8 deletions advanced_tutorials/nyc_taxi_fares/1_nyc_taxi_fares_feature_backfill.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,7 @@
" statistics_config=True,\n",
")\n",
"\n",
"rides_fg.insert(\n",
" df_rides,\n",
" write_options={\"wait_for_job\": True},\n",
")"
"rides_fg.insert(df_rides)"
]
},
{
Expand All @@ -210,10 +207,7 @@
" statistics_config=True,\n",
") \n",
"\n",
"fares_fg.insert(\n",
" df_fares, \n",
" write_options={\"wait_for_job\": True},\n",
")"
"fares_fg.insert(df_fares)"
]
},
{
Expand Down
Loading