-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for PROXY protocol #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change makes the plugin be invoked directly with the `run` method.
|
(Caveat, this PR will only likely work against Logstash 5.2 or master branches because Logstash 5.1.1 doesn't have elastic/logstash#6309) |
|
@nneul did you intend to have this not set proxy_host or proxy_port fields? The TCP input does this : https://github.com/logstash-plugins/logstash-input-tcp/blob/master/lib/logstash/inputs/tcp.rb#L183-L188No, that was not an intentional exclusion. Simple enough to add. |
|
@nneul ok cool, I will add it. |
|
This PR is blocked until Logstash 5.2 is released. Logstash 5.0 and 5.1 both have a bug fixed in 5.2 branch. |
|
@jordansissel Any update on merging this as it looks like 5.2.1 was already released? |
|
@nneul This is on my todo list for after I recover from Elasticon and this week's meetings. |
|
Woo, CI passing. |
|
@wHack LGTM, Can you update the changelog + bumping the version? One of the build job on travis was failling, It was a bundler caching issue, after clearing the cache everything went green! |
|
Anything else that needs to be done before this can be merged? |
This change makes the plugin be invoked directly with the `run` method. Fixes #38
|
I will publish this as a plugin soon. I have some new work I need to add to this plugin before publishing. |
Forked continuation of #34.