Skip to content

Conversation

@jordansissel
Copy link
Contributor

Forked continuation of #34.

@jordansissel
Copy link
Contributor Author

@nneul I've restructured some of the tests from #34 and things are passing now for me.

@jordansissel
Copy link
Contributor Author

(Caveat, this PR will only likely work against Logstash 5.2 or master branches because Logstash 5.1.1 doesn't have elastic/logstash#6309)

@nneul
Copy link
Contributor

nneul commented Jan 23, 2017


@nneul did you intend to have this not set proxy_host or proxy_port fields? The TCP input does this :

https://github.com/logstash-plugins/logstash-input-tcp/blob/master/lib/logstash/inputs/tcp.rb#L183-L188

No, that was not an intentional exclusion. Simple enough to add.

@jordansissel
Copy link
Contributor Author

@nneul ok cool, I will add it.

@jordansissel
Copy link
Contributor Author

This PR is blocked until Logstash 5.2 is released. Logstash 5.0 and 5.1 both have a bug fixed in 5.2 branch.

@nneul
Copy link
Contributor

nneul commented Feb 21, 2017

@jordansissel Any update on merging this as it looks like 5.2.1 was already released?

@jordansissel
Copy link
Contributor Author

@nneul This is on my todo list for after I recover from Elasticon and this week's meetings.

@jordansissel
Copy link
Contributor Author

Woo, CI passing.

@ph
Copy link
Contributor

ph commented Apr 5, 2017

@wHack LGTM, Can you update the changelog + bumping the version?

One of the build job on travis was failling, It was a bundler caching issue, after clearing the cache everything went green!

@nneul
Copy link
Contributor

nneul commented Apr 13, 2017

Anything else that needs to be done before this can be merged?

@elasticsearch-bot
Copy link

Jordan Sissel merged this into the following branches!

Branch Commits
master 48b08a2, c759ae8, 08b9ab0, bee7a1a, 9cb1782, 7f2c73a, d732320, a6a23f4, 4591966

elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
This change makes the plugin be invoked directly with the `run` method.

Fixes #38
elasticsearch-bot pushed a commit that referenced this pull request Apr 17, 2017
@jordansissel
Copy link
Contributor Author

I will publish this as a plugin soon. I have some new work I need to add to this plugin before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants