refactor: update token response types #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gao-sun
force-pushed
the
gao-log-7149-update-refresh-token-token-response-type-in-swift-sdk
branch
from
e37a6f0 to
51d6e58
Compare
Member
|
The test cases failed |
charIeszhao
approved these changes
Jan 8, 2024
charIeszhao
deleted the
gao-log-7149-update-refresh-token-token-response-type-in-swift-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update response types per OAuth. both refresh token and ID token should be optional.
Testing
added unit test accordingly