Attach updated endpoint signature to inner#123
Merged
Conversation
Not all endpoints accept a __signature__ attribute, nor should the cache decorator modify the decorated endpoint. Attach the signature to the returned inner function instead. While here, refactor the signature updating code, and extract it to a separate function.
Collaborator
Author
|
Note: there is one edge-case the decorator isn't handling at the moment: if the decorated endpoint uses the names This is perfectly valid, but the cache decorator will then fail with a To make that work, you'd have to generate unique names for the request and response parameters. That's well outside the scope of this PR however. |
Collaborator
Author
|
Another issue is that the decorator assumes the request and response parameters always are named 'request' and 'response' when popping these from the |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all endpoints accept a
__signature__attribute, nor should the cache decorator modify the decorated endpoint. Attach the signature to the returned inner function instead.While here, refactor the signature updating code, and extract it to a separate function.
Fixes #115