Skip to content

Conversation

@fabio-looker
Copy link
Contributor

Release-As: 23.14.0

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

RegexOptions.CultureInvariant | RegexOptions.IgnoreCase | RegexOptions.Compiled);

public const string DefaultApiVersion = "4.0";
public const string DefaultApiVersion = "3.1";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been auto-generated from an old looker.ini setting. Need to fix this

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ryandunlavy
Copy link
Collaborator

Hey @fabio-looker , since this is not yet merged I was wondering if it'd be possible to get this change in as well for the 23.14 version #1348 that was just merged. Would be helpful for our partners at Sisu.

@fabio-looker
Copy link
Contributor Author

Hey @fabio-looker , since this is not yet merged I was wondering if it'd be possible to get this change in as well for the 23.14 version #1348 that was just merged. Would be helpful for our partners at Sisu.

Jeremy assures me that release-please will automatically take it. We are hopefully close to merging this from Jeremy's run of SDK codegen because my local run is still reporting one unexpected test failure.

@ryandunlavy
Copy link
Collaborator

Hey @fabio-looker , since this is not yet merged I was wondering if it'd be possible to get this change in as well for the 23.14 version #1348 that was just merged. Would be helpful for our partners at Sisu.

Jeremy assures me that release-please will automatically take it. We are hopefully close to merging this from Jeremy's run of SDK codegen because my local run is still reporting one unexpected test failure.

Awesome, thanks Fabio

@github-actions

This comment has been minimized.

Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drstrangelooker
Copy link
Collaborator

@fabio-looker You should be ready to go after the checks run.

@github-actions
Copy link
Contributor

Python Tests

  10 files    10 suites   1m 50s ⏱️
144 tests 141 ✔️   3 💤 0 ❌
792 runs  780 ✔️ 12 💤 0 ❌

Results for commit e4a77d2.

@github-actions
Copy link
Contributor

Go Tests

    6 files      6 suites   9m 29s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit e4a77d2.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files  ±0    60 suites  ±0   14m 2s ⏱️ + 2m 19s
229 tests ±0  225 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
552 runs  ±0  536 ✔️ ±0  16 💤 ±0  0 ❌ ±0 

Results for commit e4a77d2. ± Comparison against base commit 20295d3.

@fabio-looker fabio-looker merged commit 90f3f5f into main Aug 14, 2023
@fabio-looker fabio-looker deleted the sdk_23_14 branch August 14, 2023 22:20
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants