Skip to content

fix: change visconfig types to reflect new getter #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2023
Merged

fix: change visconfig types to reflect new getter #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fa07f3
send message on vis config change
rdunlavy-google Aug 14, 2023
a047dc9
add tests for vis config change
rdunlavy-google Aug 14, 2023
4c571a2
Fix types for VisualizationConfigImpl
rdunlavy-google Aug 14, 2023
3066416
Merge branch 'main' into fix-vis-config-types
ryandunlavy Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/extension-sdk/src/connect/visualization/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export interface VisualizationConfig {
queryFieldDimensions: Dimension[]
queryFieldTableCalculations: TableCalculation[]
queryFieldPivots: PivotConfig[]
visConfig: RawVisConfig
}

export interface QueryResponse {
Expand Down
4 changes: 2 additions & 2 deletions packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ class VisualizationConfigImpl implements VisualizationConfig {
this._visConfig = visConfig
}

get visConfig(): RawVisConfig | undefined {
return this._visConfig
get visConfig(): RawVisConfig {
return this._visConfig || {}
}

get queryFieldMeasures(): Measure[] {
Expand Down