Skip to content

fix: sync up package versions #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: sync up package versions #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/embed-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"@looker/embed-components": "*",
"@looker/extension-utils": "^0.1.21",
"@looker/redux": "^0.0.1",
"@looker/sdk": "^23.2.0",
"@looker/sdk-rtl": "^21.6.0",
"@looker/sdk": "^23.14.1",
"@looker/sdk-rtl": "^21.6.1",
Comment on lines +45 to +46
Copy link

@jkaster jkaster Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set these to * does release-please update them for publishing? Or is this an extra lint/package dependency step we're going to need to add to our generation/publishing step? @treshugart would like your thoughts here

Copy link
Collaborator Author

@bryans99 bryans99 Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I dont know. I'm just syncing the packages.

Copy link

@jkaster jkaster Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. That's why I summoned Trey 😸

Copy link

@jkaster jkaster Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a blocker for your PR, which I've approved.

"@styled-icons/material": "^10.47.0",
"react": "16.14.0",
"react-dom": "16.14.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/extension-tile-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"develop": "webpack serve --hot --allowed-hosts all --port 8080 --https --config webpack.dev.config.js"
},
"dependencies": {
"@looker/extension-sdk": "^23.12.0",
"@looker/extension-sdk-react": "^23.12.0",
"@looker/sdk": "^23.12.0",
"@looker/extension-sdk": "^23.14.1",
"@looker/extension-sdk-react": "^23.14.1",
"@looker/sdk": "^23.14.1",
"@looker/components": "^3.0.8",
"@looker/icons": "^1.5.3",
"@styled-icons/material": "^10.28.0",
Expand Down