Skip to content

chore: Revert "feat: generate SDKs for Looker 23.18" #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2023
Merged

chore: Revert "feat: generate SDKs for Looker 23.18" #1388

merged 4 commits into from
Oct 20, 2023

Conversation

@drstrangelooker
Copy link
Collaborator

@drstrangelooker drstrangelooker commented Oct 20, 2023

Reverts #1378

This allows other code to land while waiting for sdk_23_18 without 3.1 endpoints.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 1b7cbd6.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Go Tests

    6 files      6 suites   11m 49s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 1b7cbd6.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Go Tests

    6 files      6 suites   11m 23s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 745cdb4.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Typescript Tests

    6 files    60 suites   12m 57s ⏱️
229 tests 224 ✔️   4 💤 1 ❌
552 runs  535 ✔️ 16 💤 1 ❌

For more details on these failures, see this check.

Results for commit 745cdb4.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Go Tests

    6 files      6 suites   9m 44s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 0a8c627.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Python Tests

    9 files      9 suites   1m 51s ⏱️
144 tests 141 ✔️   3 💤 0 ❌
676 runs  666 ✔️ 10 💤 0 ❌

Results for commit 0a8c627.

jkaster
jkaster reviewed Oct 20, 2023
View reviewed changes
Copy link

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the 23.17 version string

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Typescript Tests

    6 files    60 suites   14m 8s ⏱️
229 tests 225 ✔️   4 💤 0 ❌
552 runs  536 ✔️ 16 💤 0 ❌

Results for commit 0a8c627.

@drstrangelooker drstrangelooker merged commit 680c7ec into main Oct 20, 2023
@drstrangelooker drstrangelooker deleted the revert-1378-sdk_23_18 branch October 20, 2023 18:44
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jkaster jkaster jkaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drstrangelooker @jkaster