chore: Fix NPM publishing workflow #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremytchang
requested review from
bryans99,
deanlooker,
drstrangelooker,
jkaster and
josephaxisa
drstrangelooker
approved these changes
Feb 21, 2024
Collaborator
drstrangelooker
left a comment
drstrangelooker
left a comment
There was a problem hiding this comment.
Looks LGTM To Me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our publishing workflow was unable to execute
lerna publishto publish our npm packages because its method of executionnpm binis not supported anymore. This stackoverflow article for more context: https://stackoverflow.com/questions/9679932/how-to-use-executables-from-a-package-installed-locally-in-node-modulesnpx. I confirmed locally thatnpx lerna -hworks which means other lerna commands should work. (unable to do publishing dry run because our version of lerna is too old, and doesn't have that option)