feat: markdown, link click support, and project view for hackathon projects #877
Conversation
- removed "more info" from UI because it's not needed any more - Changed icons and some design with Jared
jkaster
requested review from
bryans99,
drstrangelooker,
fabio-looker,
jeremytchang,
josephaxisa and
lanlooker
| const newProject: unknown = { | ||
| title: '', | ||
| description: '', | ||
| description: `<Put a project overview here. Should be at least one paragraph.> |
There was a problem hiding this comment.
Feel free to update/tweak this template. This is what shows up for a new project in the Description field
bryans99
left a comment
bryans99
left a comment
There was a problem hiding this comment.
I think this is okay. A couple of minor things. Ignore comments about i18n. I can approve if you want.
| const newProject: unknown = { | ||
| title: '', | ||
| description: '', | ||
| description: `<Put a project overview here. Should be at least one paragraph.> |
packages/hackathon/src/scenes/ProjectEditorScene/components/ProjectForm.tsx
Outdated
Show resolved
Hide resolved
| if (project) { | ||
| // TODO Not sure this is needed here | ||
| if (projectId === 'new' && project._id) { | ||
| history.push(`${Routes.PROJECTS}/${project._id}`) |
There was a problem hiding this comment.
I would treat projectId === 'new' as an error. Not sure why you would want to change the current route if you have an id.
There was a problem hiding this comment.
That was copy/pasta from ProjectEditorScene and I wanted to talk with you about that bit. Now I don't need to!
| } | ||
| } else { | ||
| if (isProjectLoaded) { | ||
| dispatch(actionMessage('Invalid project', 'critical')) |
There was a problem hiding this comment.
Why is isProjectLoaded an error here?
There was a problem hiding this comment.
only gets here if project is undefined/null. If the project is "loaded" then something went wrong ... this is also copy/pasta from the Project editor scene
packages/hackathon/src/scenes/ProjectViewScene/ProjectViewScene.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const getMembers = (team: string[]) => { | ||
| try { | ||
| return team.join(', ') || 'Nobody!' |
There was a problem hiding this comment.
Definitely a TODO when we start applying i18n
| const tech = techDescriptions(project.technologies, availableTechnologies) | ||
| const members = getMembers(project.$members) | ||
| const view = `# ${project.title} | ||
| by ${members} |
There was a problem hiding this comment.
We have an i18n markdown component. Worth supporting here? Maybe not as the judges will mostly be English speakers.
There was a problem hiding this comment.
Interesting about the markdown. Again, not in scope for the upcoming Hack@Home 2021
packages/hackathon/src/scenes/ProjectViewScene/components/index.ts
Outdated
Show resolved
Hide resolved
|
Ignore. Figured it out |
|
It's the Uses line |
| invalidProject() | ||
| } | ||
| } else { | ||
| if (isProjectLoaded) { |
There was a problem hiding this comment.
Not sure about this? Why is it invalid if project is loaded?
There was a problem hiding this comment.
if project is not defined but isProjectLoaded is true, I presume that means the project was invalid. This is based on the existing code from ProjectEditor (which I was not the original author of).
| const invalidProject = () => | ||
| dispatch(actionMessage('Invalid project', 'critical')) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
What happens if this useEffect is removed?
2 participants
Added
ProjectViewProjectViewSceneChanged
Removed
Screenshots
Updated form
Preview project on form
(The
John [Object]is from bad data in my spreadsheet. Ignore)View project
Judging
View project menu
View project from judging list