feat: Looker 21.20 bindings #899

drstrangelooker · 2021-11-09T17:53:40Z

No description provided.

github-actions · 2021-11-09T18:05:58Z

Python Tests

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 49277c1.

github-actions · 2021-11-09T18:22:45Z

Typescript Tests

    6 files   75 suites 3m 49s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs 543 ✔️ 12 💤 0 ❌

Results for commit 49277c1.

…ariable called 'models'. The names interfered. I added the name models to the list of keywords and modified some methods to the proper arguments were generated with 'models_' instead.

…hods.py files

github-actions · 2021-11-09T20:35:29Z

Python Tests

    8 files     8 suites 1m 35s ⏱️
140 tests 137 ✔️ 0 💤 3 ❌
742 runs 736 ✔️ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 1d085d4.

github-actions · 2021-11-09T20:37:19Z

Codegen Tests

  1 files   6 suites 22s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 1d085d4.

github-actions · 2021-11-09T20:48:20Z

Typescript Tests

    6 files   75 suites 3m 54s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs 543 ✔️ 12 💤 0 ❌

Results for commit 1d085d4.

rollyjoel

what do you think about just changing the import inside methods.py to something like

from . import models as mdls

packages/sdk-codegen/src/python.gen.ts

github-actions · 2021-11-09T21:57:27Z

Python Tests

    9 files     9 suites 1m 55s ⏱️
140 tests 137 ✔️ 0 💤 3 ❌
765 runs 756 ✔️ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit dda374e.

github-actions · 2021-11-09T21:59:14Z

Codegen Tests

  1 files   6 suites 20s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit dda374e.

github-actions · 2021-11-09T22:09:28Z

Python Tests

    7 files     7 suites 41s ⏱️
140 tests 137 ✔️ 0 💤 3 ❌
719 runs 716 ✔️ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 94a6f63.

rollyjoel

not pretty but I think that's the best we'll do for python. I think you might need to update some tests but we'll find out

github-actions · 2021-11-09T22:18:27Z

Python Tests

    7 files     7 suites 42s ⏱️
140 tests 137 ✔️ 0 💤 3 ❌
719 runs 716 ✔️ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit d51789b.

rollyjoel · 2021-11-09T22:20:48Z

@drstrangelooker looks like the look-id int -> string change needs to be updated in the python tests

jkaster · 2021-11-09T23:38:13Z

Joel correctly called out that python.gen.spec.ts (the test for python.gen.ts) needs to be updated and should also be part of the CI call. Interesting that yarn test:sdk isn't being invoked (evidently, because it should fail).

rollyjoel · 2021-11-09T23:43:22Z

sorry, yeah what I mean is the specific language generator tests under packages/sdk-codegen/src/ seem to not be getting run as part of the build

github-actions · 2021-11-09T23:44:37Z

Python Tests

  10 files   10 suites 2m 58s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
788 runs 788 ✔️ 0 💤 0 ❌

Results for commit aabb98d.

github-actions · 2021-11-09T23:47:15Z

Codegen Tests

  1 files   6 suites 24s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit aabb98d.

github-actions · 2021-11-09T23:52:36Z

Typescript Tests

    7 files   76 suites 4m 52s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
582 runs 566 ✔️ 16 💤 0 ❌

Results for commit aabb98d.

drstrangelooker · 2021-11-10T00:11:39Z

I've been using bin/smoke and bin/unit_test. I've cleaned up the results of yarn test:sdk now.

github-actions · 2021-11-10T00:16:29Z

Python Tests

  10 files   10 suites 3m 11s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
788 runs 788 ✔️ 0 💤 0 ❌

Results for commit 61e16b2.

jkaster

LGTM. I think this should pass CI.

.github/workflows/tssdk-ci.yml

.github/workflows/python-ci.yml

README.md

packages/sdk-codegen/src/sdkModels.spec.ts

packages/sdk-codegen/src/specDiff.spec.ts

github-actions · 2021-11-10T00:18:48Z

Codegen Tests

  1 files   6 suites 27s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 61e16b2.

drstrangelooker · 2021-11-10T00:22:21Z

Found our issue. The tests are run by

yarn jest "packages/sdk-codegen(-utils|-scripts)/src" --reporters=default --reporters=jest-junit

Any tests in packages/sdk-codegen/src are skipped. Instead we need this expression:

yarn jest "packages/sdk-codegen(|-utils|-scripts)/src" --reporters=default --reporters=jest-junit

github-actions · 2021-11-10T00:23:13Z

Typescript Tests

    7 files   76 suites 4m 54s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
582 runs 566 ✔️ 16 💤 0 ❌

Results for commit 61e16b2.

drstrangelooker · 2021-11-10T00:31:09Z

I think we should fix the workflows so that the .gen.spec.ts files get run, especially because I think at least python.gen.spec.ts is broken now? #899 (comment)

Should be resolved now.

This looks like such a weird pattern yarn jest "packages/sdk-codegen(|-utils|-scripts)/src". It works on my machine but I'm waiting to see if it works properly in CI.

edit: it worked fine.

$ /home/runner/work/sdk-codegen/sdk-codegen/node_modules/.bin/jest 'packages/sdk-codegen(|-utils|-scripts)/src' --reporters=default --reporters=jest-junit
PASS packages/sdk-codegen/src/sdkModels.spec.ts (5.403 s)
PASS packages/sdk-codegen/src/python.gen.spec.ts
PASS packages/sdk-codegen/src/typescript.gen.spec.ts
PASS packages/sdk-codegen-scripts/src/convert.spec.ts (10.767 s)
PASS packages/sdk-codegen/src/kotlin.gen.spec.ts
PASS packages/sdk-codegen/src/specDiff.spec.ts
PASS packages/sdk-codegen/src/csharp.gen.spec.ts
PASS packages/sdk-codegen-scripts/src/exampleMiner.spec.ts
PASS packages/sdk-codegen/src/swift.gen.spec.ts
PASS packages/sdk-codegen/src/pseudo.gen.spec.ts
PASS packages/sdk-codegen/src/go.gen.spec.ts
PASS packages/sdk-codegen/src/codeGenerators.spec.ts
PASS packages/sdk-codegen-scripts/src/fetchSpec.spec.ts (6.928 s)

github-actions · 2021-11-10T00:38:42Z

Python Tests

  10 files   10 suites 3m 2s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
788 runs 788 ✔️ 0 💤 0 ❌

Results for commit 75298ac.

github-actions · 2021-11-10T00:41:09Z

Codegen Tests

    1 files   17 suites 34s ⏱️
395 tests 381 ✔️ 14 💤 0 ❌
396 runs 382 ✔️ 14 💤 0 ❌

Results for commit 75298ac.

Found the bug and fixed it.

github-actions · 2021-11-10T00:46:25Z

Typescript Tests

    7 files   76 suites 5m 8s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
582 runs 566 ✔️ 16 💤 0 ❌

Results for commit 75298ac.

jkaster

LGTM

.github/workflows/codegen-ci.yml

drstrangelooker requested review from jkaster and rollyjoel November 9, 2021 17:53

google-cla bot added the cla: yes label Nov 9, 2021

This comment has been minimized.

Sign in to view

drstrangelooker force-pushed the drstrangelove/release-21.20 branch from f80a8c3 to 65de88a Compare November 9, 2021 17:56

This comment has been minimized.

Sign in to view

Updated packages for Looker 21.20

49277c1

drstrangelooker force-pushed the drstrangelove/release-21.20 branch from 65de88a to 49277c1 Compare November 9, 2021 18:04

drstrangelooker added 2 commits November 9, 2021 15:27

fix: codgegen for python had a parameter called 'models' but also a v…

9ccdeb0

…ariable called 'models'. The names interfered. I added the name models to the list of keywords and modified some methods to the proper arguments were generated with 'models_' instead.

fix: generated python api with fix for 'models' references in the met…

1d085d4

…hods.py files

rollyjoel suggested changes Nov 9, 2021

View reviewed changes

packages/sdk-codegen/src/python.gen.ts Outdated Show resolved Hide resolved

drstrangelooker added 2 commits November 9, 2021 16:43

fix: factor out code to rename parameters in python generator

a7453ed

docs: added note about linting to README

dda374e

fix: alias models namespace to mdls so no conflict with parameter models

94a6f63

drstrangelooker added 2 commits November 9, 2021 17:11

fix: python api after aliasing the models namespace to mdls.

706ec45

Merge branch 'main' into drstrangelove/release-21.20

d51789b

rollyjoel self-requested a review November 9, 2021 22:16

rollyjoel previously approved these changes Nov 9, 2021

View reviewed changes

fix: fixed minor changes to specs

61e16b2

jkaster previously approved these changes Nov 10, 2021

View reviewed changes

drstrangelooker added 2 commits November 9, 2021 19:25

fix: add sdk-codegen/src tests into the mix

ad77bbd

docs: added some details to README.md on running lint

1d09feb

jeremytchang dismissed jkaster’s stale review via 61e16b2 November 10, 2021 00:29

Merge branch 'main' into drstrangelove/release-21.20

75298ac

jkaster self-requested a review November 10, 2021 01:01

drstrangelooker requested a review from rollyjoel November 10, 2021 01:02

jkaster approved these changes Nov 10, 2021

View reviewed changes

.github/workflows/codegen-ci.yml Show resolved Hide resolved

drstrangelooker merged commit 304d0d0 into main Nov 10, 2021

drstrangelooker deleted the drstrangelove/release-21.20 branch November 10, 2021 01:04

This comment has been minimized.

Sign in to view

looker-open-source-automation-bot mentioned this pull request Mar 23, 2022

chore: release main #1032

Closed

feat: Looker 21.20 bindings #899

feat: Looker 21.20 bindings #899

Uh oh!

Conversation

drstrangelooker commented Nov 9, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Typescript Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Codegen Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Typescript Tests

Uh oh!

rollyjoel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Codegen Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

rollyjoel left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

rollyjoel commented Nov 9, 2021

Uh oh!

jkaster commented Nov 9, 2021

Uh oh!

rollyjoel commented Nov 9, 2021

Uh oh!

github-actions bot commented Nov 9, 2021

Python Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Codegen Tests

Uh oh!

github-actions bot commented Nov 9, 2021

Typescript Tests

Uh oh!

drstrangelooker commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 10, 2021

Python Tests

Uh oh!

jkaster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 10, 2021

Codegen Tests

Uh oh!

drstrangelooker commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

drstrangelooker commented Nov 10, 2021 •

edited

Loading

drstrangelooker commented Nov 10, 2021 •

edited

Loading