Skip to content

Conversation

@bjorkert
Copy link
Contributor

Problem

The swiftformat script was running on LoopFollow_second, LoopFollow_third, replacing original author headers. This caused incorrect attribution since git sees the person who copied the files as the "author" in these repos.

Solution

Modified the swiftformat build script to only run on the main LoopFollow repository by checking that the folder name is exactly "LoopFollow".

Changes

  • Added folder name validation before running swiftformat
  • Script exits gracefully (exit 0) when run in non-LoopFollow directories
  • Shows informative skip message for clarity

Impact

  • Original author headers preserved in derivative repos
  • No change to main LoopFollow repo behavior
  • Build processes remain unaffected

Testing

  • Verified script runs normally in LoopFollow directory
  • Confirmed script skips execution in LoopFollow_second directory
  • Builds complete successfully in both scenarios

@bjorkert bjorkert requested a review from marionbarker July 22, 2025 19:57
@marionbarker marionbarker changed the title Only run swiftformat in the LoopFollow folder Only run swiftformat in the LoopFollow folder [ci skip] Jul 22, 2025
@marionbarker marionbarker changed the title Only run swiftformat in the LoopFollow folder [ci skip] Only run swiftformat in the LoopFollow folder [skip ci] Jul 22, 2025
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from code review and test in LoopFollow_Second and LoopFollow_Third.

Thanks for the fix.

Attempting to skip the version bump since there was no functional change. Added [skip ci] to the PR name.

@marionbarker marionbarker merged commit 2442d1b into dev Jul 22, 2025
@marionbarker marionbarker deleted the swiftformat-loopfollow branch July 23, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants