-
Notifications
You must be signed in to change notification settings - Fork 996
Add option to silence alarm with volume button #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to silence alarm with volume button #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been used in-vivo by two of the developers.
Do a quick test by triggering an alarm and observing that pressing one-time on either a volume button snoozes the alarm when the feature is enable.
EDIT: the description has been updated.
The only issue is the description of the PR says enabled by default, when in fact it is disabled by default. But very first alarm that came on was snoozed right away and log said it was the volume button that stopped it. However, that seemed to be a one-time thing. I then changed to enabled. Quit and restart the app. Then volume buttons snoozed.
Overview
This PR introduces enhancements to the LoopFollow app's alarm management system: volume button alarm silencing.
Features Added
Volume Button Alarm Silencing
Technical Implementation
Volume Button Handler
VolumeButtonHandler.swift(327 lines)Configuration
New Settings
Default Behavior
Testing & Reliability
Volume Button Detection