Fix(alarm): Correct logic for missed reading alert #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionbarker
approved these changes
Aug 15, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
code review
Approve from code review.
Test
Build LoopFollow dev on test phone
- configure to follow Loop test phone running closed loop with rPi DASH simulator and CGM readings from Nightscout (fed by upload from Mac), make sure Loop is green and LoopFollow is following
- interrupt glucose readings sent to Nightscout
- set alarm to alert for missed readings after 11 minutes
- wait 15 minutes for alarm (to not happen)
- last glucose reading in NS at 10:48
- get distracted - it is now 11:13 and there is no Missed Reading Alert
- this demonstrates the error that is being fixed
Build with this version of code
- get missed reading alarm almost immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the Missed Reading alert would not trigger when CGM data became stale.
Problem
The alert was being blocked by a global check that required all
isBGBasedalarms to have recent BG data. This directly conflicted with the purpose of the Missed Reading alert.Solution
isBGBasedto correctly use the system's debounce logic (lastBGAlarmTime).alarm.type != .missedReading, is added to the "recent data" check, allowing the alarm to fire as intended.nowtimestamp for consistency.