Remove 'Created by' line from SwiftFormat header #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Much appreciated! |
marionbarker
approved these changes
Aug 15, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
This fixes the current issue in which multiple files are modified by the script by building with Xcode.
Approve from code review and test. Only headers are modified and only the Created by line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
// Created by {author}line from the file headers generated by our SwiftFormat script.The
swiftformattool sources the author's name from the Git history. This has proven to be a source of instability and code churn for our project. Operations such as squashing commits during a merge can change the perceived author of a file in Git's history.This leads to the
// Created by...line fluctuating between different developers during routine builds, creating unnecessary diffs and noise in commits.By removing this dynamic line from the header template, we ensure that file headers remain consistent and predictable across all development and CI environments. This change helps to reduce noise in our commit history and code reviews.
Changes Made
--headerparameter.--header "LoopFollow\n{file}\nCreated by {author}."--header "LoopFollow\n{file}"