Skip to content

Conversation

@codebymini
Copy link
Collaborator

This PR improves error handling and user guidance for Loop APNS remote functionality.

Changes

Error Handling:

  • Converted async/await methods to completion handler pattern for APNS operations
  • Added HTTP status code handling (400, 403, 404, 405, 410, 413, 429, 500, 503) with specific error messages
  • Implemented credential validation for APNS keys, team IDs, and device tokens
  • Standardized error responses across bolus, carbs, and override operations

User Guidance:

*Added environment-specific guidance messages for APNS configuration

  • Integrated build-type aware recommendations (Xcode vs Browser/TestFlight)
  • Provides instructions for production environment configuration
  • Shows current vs recommended environment settings

Logging:

  • Removed verbose debug logging
  • Streamlined logging to essential information only

@codebymini codebymini requested a review from bjorkert September 13, 2025 09:02
Copy link
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code review.

codebymini added a commit to CodeByMiniOrg/LoopFollow that referenced this pull request Sep 30, 2025
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The developer who created this PR has been using it in-vivo and remotely controlling Loop.

Tested by setting up LoopFollow to follow a Loop URL. All the remote control commands continue to work as expected. Sent from iOS 18.7 phone and an iOS 16.7.11 phone to the same URL using this code for carb, bolus, override start and override cancel.

@marionbarker marionbarker merged commit 2becf97 into dev Oct 1, 2025
@marionbarker marionbarker deleted the align-remote-errors branch October 1, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants