Add small delay to TOTP warning when sending carbs/insulin #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorkert
approved these changes
Oct 6, 2025
marionbarker
approved these changes
Oct 6, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Having the TOTP blocked message pop up after a successful command and before returning to the Loop Remote Control screen has bothered me in the past.
I reviewed the code and testing this in combinations with PR 445, 468 and 469 (this one).
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance TOTP warning handling in LoopAPNS views by adding a delay before displaying the warning to prevent flickering. Updated both LoopAPNSBolusView and LoopAPNSCarbsView to include a new state variable for managing the warning display.