Alarms: stamp 'last checked' on completion to avoid false positives #471
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a race where Missed Reading and Not Looping alarms could fire while BG/Loop checks were still running.
We now mark the “last checked” timestamps after the data fetch has either succeeded (and been processed) or finally failed. That way, the alarm logic only validates once the attempt is actually finished.
What changed
BG
Storage.shared.lastBGChecked.viewUpdateNSBG(...)(after observables/UI updates).MissedReadingConditionnow requires a recentlastBGChecked(≤ 6 min) before evaluating staleness.Loop
Storage.shared.lastLoopingCheckedfrom start ofwebLoadNSDeviceStatus()to the end of success handling (afterupdateDeviceStatusDisplay) and to the error path (final failure).Why
Previously, we stamped the “checked” moment at the start of network calls. If the alarm evaluator ran in parallel—while
lastLoopTimeor BG entries were still old—we could alarm prematurely.